-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 support #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 14:21
35995b9
to
284a12a
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 14:29
284a12a
to
ad1d8bb
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 14:57
ad1d8bb
to
2e30eed
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 15:10
2e30eed
to
2d50707
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 15:23
2d50707
to
7cdae8a
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 15:38
7cdae8a
to
dcacfae
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
July 27, 2024 15:43
dcacfae
to
714092c
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
August 21, 2024 09:33
714092c
to
5681e08
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
August 28, 2024 13:25
5681e08
to
580b3c1
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
October 16, 2024 12:07
580b3c1
to
cbe3fd3
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
October 16, 2024 12:18
cbe3fd3
to
5d6536a
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
October 28, 2024 10:58
5d6536a
to
2c8ea44
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
===========================================
- Coverage 91.97% 91.93% -0.05%
===========================================
Files 225 225
Lines 9650 9698 +48
Branches 987 988 +1
===========================================
+ Hits 8876 8916 +40
- Misses 585 592 +7
- Partials 189 190 +1 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
November 6, 2024 14:43
2c8ea44
to
c741095
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
December 3, 2024 10:51
c741095
to
e4f895f
Compare
dolfinus
force-pushed
the
feature/test-python3.13
branch
from
January 10, 2025 09:16
e4f895f
to
9ca9a13
Compare
IlyasDevelopment
approved these changes
Jan 10, 2025
TiGrib
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Python 3.13 does not allow inheritance like
A -> B, A -> C, B+C -> D
, this leads to raising errorTypeError: multiple bases have instance lay-out conflict
.This was used in 2 cases - mixin classes based on Pydantic models, and inheritance schema like
Options(ReadOptions, WriteOptions)
,ReadWriteFormat(ReadOnlyFormat, WriteOnlyFormat)
. Replaced with copy-paste of original classes content. This is could be a breaking change, if users made some own classes like file formats, so I've bumped version to 0.13.0.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)