Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support #298

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add Python 3.13 support #298

merged 1 commit into from
Jan 10, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jul 27, 2024

Change Summary

Python 3.13 does not allow inheritance like A -> B, A -> C, B+C -> D, this leads to raising error TypeError: multiple bases have instance lay-out conflict.

This was used in 2 cases - mixin classes based on Pydantic models, and inheritance schema like Options(ReadOptions, WriteOptions), ReadWriteFormat(ReadOnlyFormat, WriteOnlyFormat). Replaced with copy-paste of original classes content. This is could be a breaking change, if users made some own classes like file formats, so I've bumped version to 0.13.0.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jul 27, 2024
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 35995b9 to 284a12a Compare July 27, 2024 14:21
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 284a12a to ad1d8bb Compare July 27, 2024 14:29
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from ad1d8bb to 2e30eed Compare July 27, 2024 14:57
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 2e30eed to 2d50707 Compare July 27, 2024 15:10
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 2d50707 to 7cdae8a Compare July 27, 2024 15:23
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 7cdae8a to dcacfae Compare July 27, 2024 15:38
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from dcacfae to 714092c Compare July 27, 2024 15:43
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 714092c to 5681e08 Compare August 21, 2024 09:33
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 5681e08 to 580b3c1 Compare August 28, 2024 13:25
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 580b3c1 to cbe3fd3 Compare October 16, 2024 12:07
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from cbe3fd3 to 5d6536a Compare October 16, 2024 12:18
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from 5d6536a to 2c8ea44 Compare October 28, 2024 10:58
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (debf890) to head (9ca9a13).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ection/db_connection/jdbc_connection/connection.py 77.14% 5 Missing and 3 partials ⚠️
...l/connection/db_connection/greenplum/connection.py 91.66% 1 Missing ⚠️
.../connection/db_connection/jdbc_mixin/connection.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
- Coverage    91.97%   91.93%   -0.05%     
===========================================
  Files          225      225              
  Lines         9650     9698      +48     
  Branches       987      988       +1     
===========================================
+ Hits          8876     8916      +40     
- Misses         585      592       +7     
- Partials       189      190       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus changed the title Test Python 3.13 Add Python 3.13 support Dec 3, 2024
@dolfinus dolfinus force-pushed the feature/test-python3.13 branch from e4f895f to 9ca9a13 Compare January 10, 2025 09:16
@dolfinus dolfinus marked this pull request as ready for review January 10, 2025 09:18
@dolfinus dolfinus merged commit d0e647d into develop Jan 10, 2025
43 of 44 checks passed
@dolfinus dolfinus deleted the feature/test-python3.13 branch January 10, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants