Fix useFacetUnwrap support for custom equality check (#140)

* Fix test catching the bug

* Properly checks if the new value is the same as the previous one

The prior implementation would always compare the previous with itself

* Refactor so that in never calls setState, unless needed

* Revert "Refactor so that in never calls setState, unless needed"

This reverts commit dd53972.

packages/@react-facet/core/src/hooks/useFacetUnwrap.spec.tsx

@@ -228,7 +228,7 @@ it('does not trigger a re-render when changing a facet from undefined to undefin
 })
 
 it('supports custom equality checks', () => {
- const value = {}
+ const value = { prop: 'initial' }
  const demoFacet = createFacet({ initialValue: value })
 
  // Dummy equality check that always returns its not equal
@@ -267,4 +267,18 @@ it('supports custom equality checks', () => {
  expect(check).toHaveBeenCalledTimes(1) // but the check should be executed
  expect(check).toHaveBeenCalledWith(value) // passing the value (which should be the same)
  expect(renderedMock).toHaveBeenCalledTimes(1) // and since the equality check always returns "false", we have a render
+
+ jest.clearAllMocks()
+
+ const newValue = { prop: 'new' }
+
+ // If we update with a new object,
+ act(() => {
+ demoFacet.set(newValue)
+ })
+
+ expect(equalityCheck).toHaveBeenCalledTimes(0) // equality check was already initialized
+ expect(check).toHaveBeenCalledTimes(1) // but the check should be executed
+ expect(check).toHaveBeenCalledWith(newValue) // passing the new value
+ expect(renderedMock).toHaveBeenCalledTimes(1) // and since the equality check always returns "false", we have a render
 })

packages/@react-facet/core/src/hooks/useFacetUnwrap.ts

@@ -61,7 +61,7 @@ export function useFacetUnwrap<T extends Value>(
  return { value }
  }
 
- if (previousValue !== NO_VALUE && isEqual(previousValue)) {
+ if (previousValue !== NO_VALUE && isEqual(value)) {
  return previousState
  }