Fix useFacetUnwrap support for custom equality check #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior implementation would always compare the previous with itself
This reverts commit dd53972.
marlonicus
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Fix test catching the bug * Properly checks if the new value is the same as the previous one The prior implementation would always compare the previous with itself * Refactor so that in never calls setState, unless needed * Revert "Refactor so that in never calls setState, unless needed" This reverts commit dd53972.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom equality checks for the
useFacetUnwrapnever worked, and instead would always consider the value to never change.Luckily, we never used this feature internally. 🙈