Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useFacetUnwrap support for custom equality check #140

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fix useFacetUnwrap support for custom equality check #140

merged 4 commits into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. Fix test catching the bug

    @pirelenito
    pirelenito committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    da13cc1 View commit details
    Browse the repository at this point in the history

  2. Properly checks if the new value is the same as the previous one 

    The prior implementation would always compare the previous with itself
    @pirelenito
    pirelenito committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f1bc2db View commit details
    Browse the repository at this point in the history

  3. Refactor so that in never calls setState, unless needed

    @pirelenito
    pirelenito committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    dd53972 View commit details
    Browse the repository at this point in the history

  4. Revert "Refactor so that in never calls setState, unless needed" 

    This reverts commit dd53972.
    @pirelenito
    pirelenito committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a3e37a3 View commit details
    Browse the repository at this point in the history