-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⏫ upgrade to Polkadot SDK v1.10.0 #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beast!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, remarkable work. Very tidy and organised, and excellent PR docs on what were the changes.
Solve conflicts and ready to merge.
use sp_trie::Trie; | ||
use sp_trie::{TrieDBBuilder, TrieLayout}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use sp_trie::Trie; | |
use sp_trie::{TrieDBBuilder, TrieLayout}; | |
use sp_trie::{TrieDBBuilder, TrieLayout, Trie}; |
This PR upgrades dependencies to polkadot-sdk v1.10.0. Notable changes:
get_claim_for
anditer_claims_at_depth
methods, useful for checking which parachains had claims over which cores at a certain depth (blocks in the future, depth 0 = very next block)StorageItem::<T, I>::get()
is used insteadteleport_assets
andreserve_transfer_assets
. NOTE: No change needed since we use the generictransfer_assets
execute
andsend
forexecute_blob
andsend_blob
. NOTE: Updated xcm-simulator tests to change deprecated functions in this PR.on_idle
. NOTE: Implemented in this PR, but IdleMaxServiceWeight (the maximum weight to be used from remaining weight for processing enqueued messages on idle) is set to a placeholder, we should update it after benchmarking.schedule_code_upgrade
to not wait for the parachain to progress (useful to know, it's now easier to unbrick a parachain)execute_blob
andsend_blob
(which require as input the encoded XCM)Critical warning: since storage from
cumulus-pallet-parachain-system
is made public in polkadot-sdk v1.13.0 and itspallet::getter
s have been removed, we have to mock getting from its storage. This HAS to be removed when upgrading to v1.13.0.