Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed pallet::getter usage from cumulus pallets #3471

Merged
merged 12 commits into from
Mar 18, 2024
Merged

removed pallet::getter usage from cumulus pallets #3471

merged 12 commits into from
Mar 18, 2024

Conversation

muraca
Copy link
Contributor

@muraca muraca commented Feb 23, 2024 •
edited
Loading

Part of #3326

@ggwpez @kianenigma @shawntabrizi

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

@muraca
removed pallet::getter from cumulus-pallet-aura-ext
a5fd4ed 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
removed pallet::getter from pallet-collator-selection
dd500ad 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
removed pallet::getter from cumulus-pallet-parachain-system
6088fc7 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
removed pallet::getter from staging-parachain-info
bf056dd 
ran `cargo fmt`

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
prdoc for paritytech#3471
089c38d 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca muraca marked this pull request as ready for review February 23, 2024 21:38
@muraca muraca mentioned this pull request Feb 23, 2024
Open
63 tasks
kianenigma
kianenigma approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@muraca muraca changed the title removed pallet::getter from cumulus pallets removed pallet::getter usage from cumulus pallets Mar 5, 2024
muraca and others added 3 commits March 11, 2024 16:36
@muraca
implemented parachain_id
2eeaa27 
allowing a cleaner solution and retrocompatibility

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
Merge branch 'master' into getters/cumulus
54347fc
@muraca
Merge branch 'master' into getters/cumulus
9f21efb
@kianenigma kianenigma added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. labels Mar 12, 2024
@kianenigma
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@kianenigma A referendum for a small (20 DOT) tip was successfully submitted for @muraca (12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp on polkadot).

Referendum number: 571.
tip

muraca and others added 2 commits March 13, 2024 08:57
@kianenigma
Copy link
Contributor

@maksimryndin seems like ref was created, but no description was set?

@maksimryndin
Copy link
Contributor

@maksimryndin seems like ref was created, but no description was set?

@kianenigma Sorry, could you please elaborate?

@muraca
Copy link
Contributor Author

muraca commented Mar 15, 2024 •
edited
Loading

@maksimryndin the referendum has been created without any title or description.
However, this didn't happen for other referendums created later by the tip bot, such as 578 and 579.

@maksimryndin
Copy link
Contributor

maksimryndin commented Mar 15, 2024 •
edited
Loading

@maksimryndin the referendum has been created without any title or description. However, this didn't happen for other referendums created later by the tip bot, such as 578 and 579.

@muraca thank you for the explanation! There was an issue paritytech/substrate-tip-bot#133
and @mordamax helped me with the ref.

@liamaharon liamaharon added this pull request to the merge queue Mar 18, 2024
Merged via the queue into paritytech:master with commit 610987a Mar 18, 2024
129 of 133 checks passed
ordian pushed a commit that referenced this pull request Mar 19, 2024
@muraca @ordian
removed pallet::getter usage from cumulus pallets (#3471)
4f4ef35 
Part of #3326 

@ggwpez @kianenigma @shawntabrizi

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

---------

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
ordian added a commit that referenced this pull request Mar 19, 2024
@ordian
Merge branch 'master' into ao-send-parent-head-data
6d34dcb 
* master:
  Make `availability-recovery-regression-bench` a benchmark (#3741)
  Add HRMP notification handlers to the xcm-executor (#3696)
  Bump the known_good_semver group with 2 updates (#3726)
  removed `pallet::getter` usage from cumulus pallets (#3471)
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@muraca @dharjeezy
removed pallet::getter usage from cumulus pallets (paritytech#3471)
1aa49f0 
Part of paritytech#3326 

@ggwpez @kianenigma @shawntabrizi

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

---------

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@Morganamilo Morganamilo mentioned this pull request Apr 4, 2024
Closed
12 tasks
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@chungquantin chungquantin mentioned this pull request Aug 13, 2024
Merged
@TDemeco TDemeco mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gupnik gupnik gupnik approved these changes

@liamaharon liamaharon liamaharon approved these changes

@kianenigma kianenigma kianenigma approved these changes

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

@ggwpez ggwpez Awaiting requested review from ggwpez

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@muraca @kianenigma @maksimryndin @liamaharon @gupnik