Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make availability-recovery-regression-bench a benchmark #3741

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Make availability-recovery-regression-bench a benchmark #3741

merged 1 commit into from
Mar 19, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 18, 2024

Closes: #3704

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Mar 18, 2024
@bkchr bkchr requested a review from a team as a code owner March 18, 2024 20:46
@bkchr bkchr mentioned this pull request Mar 18, 2024
Closed
ggwpez
ggwpez approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is more proper.

sandreim
sandreim approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clean cut indeed. I assume this still fails the pipeline if benchmarks fails assuming we allow_failure: false, right ?

AndreiEres
AndreiEres approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@AndreiEres AndreiEres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bkchr
Copy link
Member Author

bkchr commented Mar 19, 2024

. I assume this still fails the pipeline if benchmarks fails assuming we allow_failure: false, right ?

I tested it, cargo bench propagates the error. However, just setting allow_failure isn't enough as github is not respecting this.

@bkchr bkchr added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit 430ad2f Mar 19, 2024
137 of 142 checks passed
@bkchr bkchr deleted the bkchr-availability-benchmark branch March 19, 2024 09:27
ordian pushed a commit that referenced this pull request Mar 19, 2024
@bkchr @ordian
Make availability-recovery-regression-bench a benchmark (#3741)
4697b7b 
Closes: #3704
ordian added a commit that referenced this pull request Mar 19, 2024
@ordian
Merge branch 'master' into ao-send-parent-head-data
6d34dcb 
* master:
  Make `availability-recovery-regression-bench` a benchmark (#3741)
  Add HRMP notification handlers to the xcm-executor (#3696)
  Bump the known_good_semver group with 2 updates (#3726)
  removed `pallet::getter` usage from cumulus pallets (#3471)
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@bkchr @dharjeezy
Make availability-recovery-regression-bench a benchmark (paritytech…
0f20ed9 
…#3741)

Closes: paritytech#3704
@AndreiEres AndreiEres mentioned this pull request Mar 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2024
@AndreiEres @sandreim
@alindima @ggwpez @pepoviola @serban300 @acatangiu @bkchr @lexnv @niklasad1 @dastansam @liamaharon @claravanstaden @yrong @vgeddes @svyatonik
Remove nextest filtration (#3885)
665e365 
Fixes
#3884 (comment)

After moving regression tests to benchmarks
(#3741) we don't need to
filter tests anymore.

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Alin Dima <alin@parity.io>
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Dastan <88332432+dastansam@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Ron <yrong1997@gmail.com>
Co-authored-by: Vincent Geddes <vincent@snowfork.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
@AndreiEres @sandreim
@alindima @ggwpez @pepoviola @serban300 @acatangiu @bkchr @lexnv @niklasad1 @dastansam @liamaharon @claravanstaden @yrong @vgeddes @svyatonik @Ank4n
Remove nextest filtration (#3885)
c47d5f4 
Fixes
#3884 (comment)

After moving regression tests to benchmarks
(#3741) we don't need to
filter tests anymore.

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Alin Dima <alin@parity.io>
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Dastan <88332432+dastansam@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Ron <yrong1997@gmail.com>
Co-authored-by: Vincent Geddes <vincent@snowfork.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@AndreiEres @sandreim
@alindima @ggwpez @pepoviola @serban300 @acatangiu @bkchr @lexnv @niklasad1 @dastansam @liamaharon @claravanstaden @yrong @vgeddes @svyatonik @dharjeezy
Remove nextest filtration (paritytech#3885)
1454fde 
Fixes
paritytech#3884 (comment)

After moving regression tests to benchmarks
(paritytech#3741) we don't need to
filter tests anymore.

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Alin Dima <alin@parity.io>
Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Dastan <88332432+dastansam@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Ron <yrong1997@gmail.com>
Co-authored-by: Vincent Geddes <vincent@snowfork.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcny rcny rcny approved these changes

@ggwpez ggwpez ggwpez approved these changes

@AndreiEres AndreiEres AndreiEres approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Availability recovery bench hangs test runner
5 participants
@bkchr @rcny @ggwpez @AndreiEres @sandreim