Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the talk screen to NUI #667

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request converts the Talk screen to NUI. It should functionally identically to before, although there may be some minor visual differences.

Before

image

After

image

Testing

  • Start a new game (or continue an existing one)
  • Fly towards the starting station until the Talk button is enabled
  • Verify that the talk screen opens when you click on the Talk button
  • Verify that each of the buttons on the talk screen behaves as before e.g.
    • Verify that the buy screen opens when you click on the Buy button (or press the B key)
    • Verify that the sell screen opens when you click on the Sell button (or press the S key)
    • Verify that the Change Ship screen opens when you click on the Change Ship button (or press the C key)
    • Verify that the Hire Ship screen opens when you click on the Hire button (or press the H key)
    • Verify that the talk screen closes when you click on its Close button (or press the Escape key)
  • Test that this works for both the starting station and the stations found on planets

Notes

@BenjaminAmos BenjaminAmos changed the base branch from develop to nui-ported-screens October 31, 2022 22:52
@BenjaminAmos BenjaminAmos force-pushed the nui-screen-conversion/talk-screen branch 2 times, most recently from 0480e8e to 5f93937 Compare October 31, 2022 23:33
@BenjaminAmos BenjaminAmos force-pushed the nui-screen-conversion/talk-screen branch from 5f93937 to 3904ff5 Compare October 31, 2022 23:41
@BenjaminAmos BenjaminAmos merged commit 7ec98eb into MovingBlocks:nui-ported-screens Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant