Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the inventory screen (and all InventoryOperationsScreen screens) to NUI #668

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request converts the in-game inventory screen to use NUI. It should function almost identically to before, however it may look a bit different. Any UI design critiques would be appreciated.

Testing

  • This pull request affects all screens that use the inventory's functionality.
  • The following screens are affected and should be double-checked against an older build to identify possible regressions:
    • TutorialManager
    • BuyItemsScreen
    • SellItemsScreen
    • ChangeShipScreen
    • ChooseMercenaryScreen
    • GiveItemsScreen (give items to a mercenary)
    • HireShipsScreen
    • ShowInventory (the "Items" screen)
    • TakeItems (take items from a mercenary)
  • As a guide, at least the following things should be checked:
    • Is the appearence similar to before (or better)?
    • Do all of the key-bindings work as before?
    • Does the screen function the same as before (or better)?
    • Can you buy items? Does it cost you to do so?
    • Can you sell items? Do you profit from doing so?
    • Can you hire mercenaries? Will they follow you afterwards?
    • Can you change ship? Will it cost you to do so? Does your ship actually change?

Notes

@BenjaminAmos BenjaminAmos changed the base branch from develop to nui-ported-screens October 31, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant