Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for replacing skins through deltas #3241

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

vampcat
Copy link
Contributor

@vampcat vampcat commented Jan 23, 2018

Partially solution for the problems outlined in #3238.

Changes

Allows module creators to replace the skin for a particular UI screen by providing a delta file. Note that only support for skin has been added right now, and (if required) everything else will have to implemented separately.

How to test

(I'm considering you're developing Sample module, and want to replace the skin used in toolbar.ui (hud) with a custom skin (hudLarge))

  • Checkout the PR
  • Add the skin you want to replace an existing skin with (in my example, create \modules\Sample\assets\skins\hudLarge.skin)
  • Add the delta for the UI skin you want to update (in my example, add a file \modules\Sample\deltas\engine\ui\hud\toolbar.ui with the following content: { "skin": "HUDLarge" })
  • Run the game, and have the skin in toolbar.ui screen replaced from hud to hudLarge

@skaldarnar skaldarnar self-requested a review January 23, 2018 09:01
@skaldarnar skaldarnar self-assigned this Jan 23, 2018
@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out well. Would you please write some lines of Javadoc stating what you already said in the PR comment.

Otherwise, good to merge 👍

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@vampcat vampcat added the Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience label Jan 24, 2018
@skaldarnar skaldarnar merged commit 86d3fc5 into MovingBlocks:develop Jan 24, 2018
@Cervator Cervator added this to the Alpha 9 milestone Feb 6, 2018
@vampcat vampcat deleted the uiDelta branch February 18, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants