Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old fellowships related files and code #2812

Closed
mmmavis opened this issue Mar 14, 2019 · 7 comments
Closed

Remove old fellowships related files and code #2812

mmmavis opened this issue Mar 14, 2019 · 7 comments

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 14, 2019

Now that fellowships bits have been CMSified, please remove old static/hardcoded fellowships related files and code. Thanks!

@youriwims
Copy link
Contributor

youriwims commented Mar 15, 2019

Just want to confirm that everything in network-api/networkapi/fellows/templates can be removed?

@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 15, 2019

@alanmoo @Pomax tagging you both as I wasn't involved with CMSifying fellowships work so I'm not 100% sure

My assumption is that since we have CMSified fellowships pages, we now can safely remove everything in network-api/networkapi/fellows, old SCSS, and its related template tags that are no longer in use?

@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 15, 2019

Things in network-api/networkapi/fellows include

network-api/networkapi/fellows
├── __init__.py
├── apps.py
├── migrations
│   └── __init__.py
├── templates
│   ├── application_cta_banner.html
│   ├── application_deadline.html
│   ├── contact_banner.html
│   ├── fellows_apply.html
│   ├── fellows_directory.html
│   ├── fellows_home.html
│   ├── fellows_host_org.html
│   ├── fellows_media.html
│   ├── fellows_open_web.html
│   ├── fellows_science.html
│   ├── fellows_support.html
│   ├── fellows_tech_policy.html
│   └── fellows_type.html
├── urls.py
└── views.py

@alanmoo
Copy link
Contributor

alanmoo commented Mar 18, 2019

Sounds right to me, but duplicate of #2737. Though this has more detail, so I'll close that.

@HSR05
Copy link
Contributor

HSR05 commented Mar 18, 2019

@alanmoo I was previously on #2737 . This has made it clear. So, do i keep the network-api/networkapi/fellows and remove the old static/hardcoded files in it or should i remove the whole fellows folder present in network-api/networkapi.
Kindly confirm this and i'll create a PR for it. Thankyou.

HSR05 added a commit to HSR05/foundation.mozilla.org that referenced this issue Mar 18, 2019
@HSR05 HSR05 mentioned this issue Mar 18, 2019
6 tasks
@HSR05
Copy link
Contributor

HSR05 commented Mar 18, 2019

@alanmoo I removed network-api/networkapi/fellows/templates file in the PR #2849 . Is there anything else that can be safely removed?

@alanmoo
Copy link
Contributor

alanmoo commented Mar 19, 2019

Ideally we'll be removing that entire /fellows directory, though I recognize it might need to happen in pieces. @cadecairos or @patjouk may be able to provide some guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants