Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Fellowship Directory & Related Files #2865

Merged
merged 8 commits into from
Mar 22, 2019
Merged

Remove Fellowship Directory & Related Files #2865

merged 8 commits into from
Mar 22, 2019

Conversation

youriwims
Copy link
Contributor

Closes #2812
Related PRs/issues #2849

@cadecairos cadecairos had a problem deploying to foundation-mofostaging-pr-2865 March 21, 2019 16:23 Failure
@youriwims youriwims changed the title Remove Fellow Directory & Related Files Remove Fellowship Directory & Related Files Mar 21, 2019
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2865 March 21, 2019 16:35 Inactive
@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-2865 March 21, 2019 16:35 Inactive
@youriwims youriwims had a problem deploying to foundation-mofostaging-pr-2865 March 21, 2019 17:12 Failure
@youriwims
Copy link
Contributor Author

youriwims commented Mar 21, 2019 •
edited
Loading

Ended up force removing the last few changes that dealt with the people.jsx & people.scss files. Removal of those files should be done in a separate PR to address Issue #2686, more specifically this comment.

@youriwims youriwims had a problem deploying to foundation-mofostaging-pr-2865 March 21, 2019 17:15 Failure
@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-2865 March 21, 2019 17:24 Inactive
@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-2865 March 21, 2019 18:19 Inactive
@youriwims youriwims requested review from mmmavis and patjouk and removed request for patjouk and mmmavis March 21, 2019 19:38
This was referenced Mar 21, 2019
Closed
Merged
patjouk
patjouk approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@patjouk patjouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

alanmoo
alanmoo approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI is fine

@youriwims youriwims merged commit 842cc44 into master Mar 22, 2019
@youriwims youriwims deleted the fellow-cleanup branch March 22, 2019 17:37
@youriwims youriwims restored the fellow-cleanup branch March 25, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmoo alanmoo alanmoo approved these changes

@patjouk patjouk patjouk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youriwims @patjouk @alanmoo @cadecairos