Fix for CodeHint Description CSS Issue (adobe#14728)

* Fix for overlapping dropdown div * Cleanup #1
Mu-L · Apr 25, 2019 · 188c125 · 188c125
1 parent 1b13b49
commit 188c125
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/editor/CodeHintList.js b/src/editor/CodeHintList.js
@@ -266,16 +266,12 @@ define(function (require, exports, module) {
             // attach to DOM
             $parent.append($ul);
 
-            $parent.find(".hint-list-offset").remove();
-            $("<div class='hint-list-offset'></div>").appendTo($parent);
-
             // If a a description field requested attach one
             if (this.enableDescription) {
                 // Remove the desc element first to ensure DOM order
                 $parent.find("#codehint-desc").remove();
                 $parent.append("<div id='codehint-desc' class='dropdown-menu quiet-scrollbars'></div>");
                 $ul.addClass("withDesc");
-                $parent.find(".hint-list-offset").addClass("withDesc");
             }
             this._setSelectedIndex(selectInitial ? 0 : -1);
         }
@@ -323,7 +319,7 @@ define(function (require, exports, module) {
         if (descOffset === 0) {
             descOffset = menuHeight - descOverhang;
         }
-        this.$hintMenu.find(".hint-list-offset").css("height", descOffset - 1);
+        this.$hintMenu.find("#codehint-desc").css("margin-top", descOffset - 1);
 
         return {left: posLeft, top: posTop, width: availableWidth};
     };

diff --git a/src/styles/brackets_patterns_override.less b/src/styles/brackets_patterns_override.less
@@ -586,11 +586,10 @@ a:focus {
 
 #codehint-desc {
 	background: @bc-codehint-desc;
-	position: relative;
+	position: absolute;
 	width: 100%;
 	box-sizing: border-box;
 	float: left;
-	top: 34px;
 	border-radius: 1px !important;
 	border-top-left-radius: 0px !important;
 	border-top-right-radius: 0px !important;