try dif node #146
Closed
try dif node #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MuhammedKalkan seems like they revamp the build process. To handle #145, read https://www.electronjs.org/de/docs/latest/tutorial/using-native-node-modules. Normally, this is done by electron-rebuilder, however automatic rebuild is disabled. I would not reenable the rebuild process, because its part of the postinstall script. Looking at lensapp/lens#7115, they switch from yarn back to npm. It seems like we have to replicate the steps to get an working build back. I will some efforts on a branch |
|
Hm local builds are working for macos, also windows binaries on github are also working, all built by same commands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.