Switch to using NPM workspaces #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansav
requested review from
Iku-turso and
jim-docker
and removed request for
a team
jansav
force-pushed
the
chore/npm-over-yarn
branch
from
e273308 to
9e2dc3b
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
866704b to
b9f2472
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jansav
force-pushed
the
chore/npm-over-yarn
branch
from
9e2dc3b to
6c15566
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
c0278f1 to
4c203da
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
2 times, most recently
from
7e3eb64 to
82a36af
Compare
jansav
force-pushed
the
chore/npm-over-yarn
branch
from
6c15566 to
aacf954
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This is blocked until #7113 is merged. |
jansav
force-pushed
the
chore/npm-over-yarn
branch
from
f2723ec to
121d67d
Compare
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
c8dfd49 to
c8deb4e
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
c8deb4e to
9ad3cc7
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
…nt (main) as Electron does that Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Nokel81
force-pushed
the
chore/switch-to-using-workspaces
branch
from
0344b7d to
169a740
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
previously approved these changes
Feb 17, 2023
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
0ce47a2 to
e19c82e
Compare
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Installing Electron in Windows seems to be broken in this regards. Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
force-pushed
the
chore/switch-to-using-workspaces
branch
from
e19c82e to
b5d59e1
Compare
Iku-turso
approved these changes
Feb 20, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will turn on NPM workspaces to prevent duplicate instances of same dependency in application bundle.
Fixes #7065