feat: add sidebar as app drag pane #130
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant SpaceSidebar
participant SidebarTabDropTarget
SpaceSidebar->>SidebarTabDropTarget: Render with className="app-drag"
SidebarTabDropTarget->>SidebarTabDropTarget: Merge className with internal classes
SidebarTabDropTarget-->>SpaceSidebar: Rendered with combined classes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/renderer/src/components/browser-ui/sidebar/content/sidebar-tab-drop-target.tsx (1)
82-82: Consider suppressing the element from the accessibility treeThe div is purely decorative/functional (drag handle) and has no content. Screen readers may announce it as an empty landmark.
Addrole="presentation"oraria-hidden="true"to avoid confusing assistive tech.- <div className={cn("flex-1 flex flex-col", className)} ref={dropTargetRef} onDoubleClick={handleDoubleClick}></div> + <div + className={cn("flex-1 flex flex-col", className)} + ref={dropTargetRef} + onDoubleClick={handleDoubleClick} + role="presentation" + aria-hidden="true" + />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/renderer/src/components/browser-ui/sidebar/content/sidebar-tab-drop-target.tsx(2 hunks)src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/renderer/src/components/browser-ui/sidebar/content/sidebar-tab-drop-target.tsx (1)
src/renderer/src/lib/utils.ts (1)
cn(5-7)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (macos-13)
- GitHub Check: build (ubuntu-24.04-arm)
- GitHub Check: build (macos-latest)
🔇 Additional comments (2)
src/renderer/src/components/browser-ui/sidebar/content/sidebar-tab-drop-target.tsx (1)
16-20: Prop plumbing looks solid
classNameis added to the type, destructured, and forwarded throughcn– implementation is correct and non-breaking.src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx (1)
157-158: I’d like to pinpoint whereSidebarTabDropTargetis defined by checking its import path. Please run:#!/usr/bin/env bash set -e echo "=== Imports in space-sidebar.tsx ===" sed -n '1,50p' src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx
|
thank you for this!! will check it in a bit <3 |
|
Just remembered something: when drag is enabled for an element, that whole section won't receive click events. That means double clicking to open the command palette won't work. There seem to be a native module for fixing it, but that will be needed before we can merge this. |
2 participants
Allows user to drag sidebar to move whole window (area selected with yellow stripes on the screenshot below) - of course these stripes are not part of the PR 😃
Summary by CodeRabbit