Skip to content

feat: add sidebar as app drag pane #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MHase wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add sidebar as app drag pane #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5822351
feat: add sidebar as app drag pane
MHase Jun 18, 2025
2f70662
chore: fix formatting
iamEvanYT Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/renderer/src/components/browser-ui/sidebar/content/sidebar-tab-drop-target.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,23 @@ import {
dropTargetForElements,
ElementDropTargetEventBasePayload
} from "@atlaskit/pragmatic-drag-and-drop/element/adapter";
import { cn } from "@/lib/utils";

type SidebarTabDropTargetProps = {
spaceData: Space;
isSpaceLight: boolean;
moveTab: (tabId: number, newPos: number) => void;
biggestIndex: number;
className?: string;
};

export function SidebarTabDropTarget({ spaceData, isSpaceLight, moveTab, biggestIndex }: SidebarTabDropTargetProps) {
export function SidebarTabDropTarget({
spaceData,
isSpaceLight,
moveTab,
biggestIndex,
className
}: SidebarTabDropTargetProps) {
const [showDropIndicator, setShowDropIndicator] = useState(false);
const dropTargetRef = useRef<HTMLDivElement>(null);

Expand Down Expand Up @@ -77,7 +85,11 @@ export function SidebarTabDropTarget({ spaceData, isSpaceLight, moveTab, biggest
return (
<>
{showDropIndicator && <DropIndicator isSpaceLight={isSpaceLight} />}
<div className="flex-1 flex flex-col" ref={dropTargetRef} onDoubleClick={handleDoubleClick}></div>
<div
className={cn("flex-1 flex flex-col", className)}
ref={dropTargetRef}
onDoubleClick={handleDoubleClick}
></div>
</>
);
}
1 change: 1 addition & 0 deletions src/renderer/src/components/browser-ui/sidebar/content/space-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ export function SpaceSidebar({ space }: { space: Space }) {
isSpaceLight={isSpaceLight}
moveTab={moveTab}
biggestIndex={sortedTabGroups.length - 1}
className="app-drag"
/>
</AnimatePresence>
</div>
Expand Down
Loading