Mail button without title generates invalid mailto link #478
Comments
jhinzmann
added a commit
to jhinzmann/ngx-sharebuttons
that referenced
this issue
Jul 24, 2020
Empty params produced invalid URLs by adding an unnecessary '&' in the URL fixes MurhafSousli#478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am submitting a
What is the expected behavior?
The email button should set the URL as body text even when no further params are given.
What is the current behavior?
The generated share URL looks like
mailto:?&body=https%3A%2F%2Fngx-sharebuttons-6xp6ew.stackblitz.io%2F%23%2Fwhen no title is given.This URL is invalid since the '?' is directly followed by an '&'.
Therefore the mail client opens but does not set anything in the mail body.
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
The mail button should be usable without providing a title.
Which versions are you using for the following packages?
Share buttons: 8.0.0
The text was updated successfully, but these errors were encountered: