Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share-button): Skip empty params in shareUrl serialization #479

Merged
merged 1 commit into from
Jul 25, 2020
Merged

fix(share-button): Skip empty params in shareUrl serialization #479

merged 1 commit into from
Jul 25, 2020

Conversation

jhinzmann
Copy link

Empty params produced invalid URLs by adding an unnecessary & in the URL

fixes #478

@jhinzmann
fix(share-button): Skip empty params in shareUrl serialization
7848d29 
Empty params produced invalid URLs by adding an unnecessary '&' in the URL

fixes MurhafSousli#478
@MurhafSousli MurhafSousli merged commit bf8de3e into MurhafSousli:master Jul 25, 2020
@MurhafSousli
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mail button without title generates invalid mailto link
2 participants
@jhinzmann @MurhafSousli