Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Update PHPUnit #725

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[TASK] Update PHPUnit #725

merged 1 commit into from
Sep 20, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added dependencies Pull requests that update a dependency file backport labels Sep 20, 2024
@oliverklee oliverklee added this to the 8.6.1 or 8.7.0 milestone Sep 20, 2024
@oliverklee oliverklee requested a review from JakeQZ September 20, 2024 12:16
@oliverklee oliverklee self-assigned this Sep 20, 2024
JakeQZ
JakeQZ approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to require specific versions of PHPUnit, as we do in Emogrifier, in case an update breaks the build? (Though that's beyond the scope of this PR.)

@JakeQZ JakeQZ merged commit 81c426f into v8.x Sep 20, 2024
26 checks passed
@JakeQZ JakeQZ deleted the backport/update-phpunit branch September 20, 2024 16:47
@oliverklee
Copy link
Contributor Author

We indeed do! PR incoming …

westonruter added a commit to westonruter/PHP-CSS-Parser that referenced this pull request Nov 4, 2024
@westonruter
Merge branch 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser …
21a5de3 
…into fix/malformed-identifier

* 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits)
  [CLEANUP] Autoformat the code (MyIntervals#749)
  [TASK] Prepare the 8.7.0 release (MyIntervals#742)
  [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751)
  [CLEANUP] Autoformat the changelog (MyIntervals#750)
  [TASK] Configure PHPUnit to be more strict (MyIntervals#744)
  [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746)
  [BUGFIX] Revert broken support for multiple comments (MyIntervals#741)
  [TASK] Add some more tests for parsing comments (MyIntervals#739)
  [TASK] Use fixed PHPUnit versions (MyIntervals#726)
  [TASK] Update PHPUnit (MyIntervals#725)
  [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723)
  [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719)
  [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711)
  [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703)
  [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701)
  [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697)
  [TASK] Also allow higher versions of PHPUnit (MyIntervals#682)
  [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695)
  [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692)
  [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
backport dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
8.7.0: Add support for PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ