[BUGFIX] Avoid implicit nullable parameters #746
Conversation
This avoids deprecation warnings in PHP 8.4. Unfortunately, we need to remove the native type declaration for this to keep supporting PHP down to version 5.6.
|
Demo with PHPUnit set to fail on deprecations: #745 |
There was a problem hiding this comment.
Unfortunately, we need to remove the native type declaration for this to keep supporting PHP down to version 5.6.
I feared even worse: that it might not be possible to support all PHP versions, 5.6 through 8.4.
PHPDoc @params all present and correct where they needed to be reintroduced.
|
For what it's worth, WordPress's minimum version requirement is now PHP 7.2. So if this was what was holding back abandoning PHP 5.6 support, then this is no longer the case. |
Thanks. Yes, it may have been easier to make a 9.0.0 release supporting PHP 8.4, also ditching support for PHP<7,2, with other planned or already-implemented breaking changes then moved to a 10.0.0 milestone. WordPress wasn't a particular consideration; I think it was more about making a minor release to support PHP 8.4 if possible, so that other breaking changes already on But by the time you've found out what the problem is, you've usually pretty-much found a fix, so there's then less work involved in carrying on that same path. In this case, that path leads to release that supports PHP versions from 5.6 through 8.4, though is missing some type annotations (but which are still present on the |
…into fix/malformed-identifier * 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits) [CLEANUP] Autoformat the code (MyIntervals#749) [TASK] Prepare the 8.7.0 release (MyIntervals#742) [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751) [CLEANUP] Autoformat the changelog (MyIntervals#750) [TASK] Configure PHPUnit to be more strict (MyIntervals#744) [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746) [BUGFIX] Revert broken support for multiple comments (MyIntervals#741) [TASK] Add some more tests for parsing comments (MyIntervals#739) [TASK] Use fixed PHPUnit versions (MyIntervals#726) [TASK] Update PHPUnit (MyIntervals#725) [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723) [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719) [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711) [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703) [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701) [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697) [TASK] Also allow higher versions of PHPUnit (MyIntervals#682) [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695) [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692) [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683) ...
This avoids deprecation warnings in PHP 8.4.
Unfortunately, we need to remove the native type declaration for this to keep supporting PHP down to version 5.6.