Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-establish support for PHP 7.2 #1207

Closed
oliverklee opened this issue Jan 13, 2023 · 3 comments
Closed

Re-establish support for PHP 7.2 #1207

oliverklee opened this issue Jan 13, 2023 · 3 comments
Assignees
@oliverklee
Labels
wontimplement
Milestone
8.0.0

Comments

@oliverklee
Copy link
Contributor

Revert #1111.
@oliverklee oliverklee added this to the 8.0.0 milestone Jan 13, 2023
@oliverklee oliverklee changed the title Re-add support for PHP 7.2 Re-establish support for PHP 7.2 Jan 13, 2023
@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 16, 2023

We can mark all EOL versions of PHP as deprecated, indicating that support/comatibility may be removed in a future major release, without actually removing such support in the next major release if there is no reason for us to do so. (Buyer beware - but hosting many websites through a single version of PHP [as most website hosting companies require], I can tell you that an enforced PHP upgrade actually prevents an upgrade, because some sites are not ready and/or have not been tested against the lastest PHP, and if I don't have time to do the testing and due diligence against the latest version, then nothing can be updated.)

@oliverklee oliverklee self-assigned this Jan 16, 2023
oliverklee added a commit that referenced this issue Jan 16, 2023
@oliverklee
[FEATURE] Re-establish support for PHP 7.2
af7b34c 
This reverts commit 9cd1e60.

Fixes #1207
@oliverklee oliverklee mentioned this issue Jan 16, 2023
Closed
@JakeQZ JakeQZ mentioned this issue Feb 6, 2023
Open
@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 8, 2023 •
edited
Loading

Just realized that willnotimplement should be wontimplement, to be consistent with wontfix. Guess you can just rename the label - ?

@oliverklee
Copy link
Contributor Author

Thanks, done.

@JakeQZ JakeQZ mentioned this issue Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
wontimplement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[FEATURE] Re-establish support for PHP 7.2 MyIntervals/emogrifier
2 participants
@oliverklee @JakeQZ