Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

tts discarding path #2929

Closed
JarbasAl opened this issue Jun 24, 2021 · 1 comment · Fixed by #2934
Closed

tts discarding path #2929

JarbasAl opened this issue Jun 24, 2021 · 1 comment · Fixed by #2934

Comments

@JarbasAl
Copy link
Contributor

the latest cache refactor introduced an issue in TTS handling,

a file path is requested, but TTS engines return the path where the file was actually created, mycroft is discarding this path and using the originally requested path instead, meaning the file might not exist when playback starts

issue introduced in #2853

proposed fix: https://github.com/HelloChatterbox/HolmesV/pull/60
@krisgesling
Copy link
Contributor

Yeah I can see the argument that the get_tts() method returns a file path, so why aren't we using it. However I'm also wondering why the TTS engine is writing the files to a different path than was requested?

This feels like it was an unintentional breaking change as we previously used the return path. Perhaps we revert to use the returned path, but deprecate it and switch to the requested path in the next major release. Unless there's a reason why each specific TTS engine needs to define where the files reside?

krisgesling added a commit that referenced this issue Jun 28, 2021
@krisgesling
Use returned TTS audio file path
4a46881 
This reverts an unintentional breaking change.
A TTS engine may return a different file path than was requested.
This again uses the returned path but adds a deprecation warning
that this behaviour will no longer be supported in an upcoming release.

Fixes #2929
This was referenced Jun 28, 2021
Merged
Closed
krisgesling added a commit that referenced this issue Jun 29, 2021
@krisgesling
Use returned TTS audio file path
168cb05 
This reverts an unintentional breaking change.
A TTS engine may return a different file path than was requested.
This again uses the returned path but adds a deprecation warning
that this behaviour will no longer be supported in an upcoming release.

Fixes #2929
krisgesling added a commit that referenced this issue Jun 29, 2021
@krisgesling
Use returned TTS audio file path
0394568 
This reverts an unintentional breaking change.
A TTS engine may return a different file path than was requested.
This again uses the returned path but adds a deprecation warning
that this behaviour will no longer be supported in an upcoming release.

Fixes #2929
krisgesling added a commit that referenced this issue Jun 29, 2021
@krisgesling
Merge pull request #2934 from MycroftAI/bugfix/tts-audio-file-path
6099da1 
Fix #2929: use returned TTS audio file path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2929: use returned TTS audio file path MycroftAI/mycroft-core
2 participants
@krisgesling @JarbasAl