-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Hello @chrisveilleux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-11 03:16:44 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Great to get rid of the copy from persistent cache to the tmp one.
I noted two things (one that is an iseue, and one that may just be me not quite grasping the idea)
Voight Kampff Integration Test Failed (Results). |
2 similar comments
Voight Kampff Integration Test Failed (Results). |
Voight Kampff Integration Test Failed (Results). |
252dc43
to
86febca
Compare
Voight Kampff Integration Test Failed (Results). |
1 similar comment
Voight Kampff Integration Test Failed (Results). |
…n the temporary cache directory should have been.
Voight Kampff Integration Test Failed (Results). |
Voight Kampff Integration Test Succeeded (Results) |
Description
The impetus for this change is an attempt to fix an issue with pre-loaded cache files on devices that use Mimic2.
How to test
Check that persistent cache files are not in
/tmp
and still get used when requested.Contributor license agreement signed?
CLA [Y]