fix/intent_api

[JarbasAl]

the latest intent refactor #2599 seems to have forgotten the intent api #2468 was a thing and borked it

this PR fixes it and does some extra cleanup moving things around to more logical places. The bus handlers were split across Padatious and IntentService and have now been unified

To test see #2468

This one can't be monkey patched at runtime, please review and merge

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[forslund]

Thanks for fixing my mess @JarbasAI. I thought I did the api correct but seem to have messed up. Can you check out the failing unittests? (I did create some to cover the intent api)

[forslund]

Should we make sure to prepend an _ to the bus handlers so we don't have to worry about breaking the api if we move those around in the future? Or maybe add that as a 21.02 task?

[forslund]

In addition to the change requests the test/unittests/skills/test_intent_service.py L290 needs to be changed to self.intent_service.handle_adapt_manifest(msg)

With those changes all the tests pass again.

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[forslund]

Nice, apart from a couple of spelling mistakes it looks good. Approved

I think the changes in the object api are ok since these methods works through the messagebus and is of little use when called directly.

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[krisgesling]

Thanks to you both!!