Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

fix/padatious_mess #2843

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix/padatious_mess #2843

merged 1 commit into from
Mar 2, 2021

Conversation

JarbasAl
Copy link
Contributor

@JarbasAl JarbasAl commented Feb 18, 2021 •
edited
Loading

intent service code for padatious is duplicated

this PR removes old location

@pep8speaks
Copy link

pep8speaks commented Feb 18, 2021 •
edited
Loading

Hello @JarbasAl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-18 13:32:23 UTC

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Feb 18, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

Thanks Jarbas, looks good. You can probably remove the old location completely now that the next version should be 21.02 it can be dropped.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

forslund
forslund approved these changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad to be rid of it :)

@krisgesling krisgesling added the Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. label Feb 19, 2021
@forslund forslund merged commit 492bd22 into MycroftAI:dev Mar 2, 2021
@forslund forslund added the Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality. label Mar 2, 2021
@JarbasAl JarbasAl deleted the fix/padatious_mess branch October 26, 2021 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@forslund forslund forslund approved these changes

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JarbasAl @pep8speaks @devops-mycroft @forslund @krisgesling