Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe to/Unsubscribe from an Issue or Merge Request #221

Closed
connorshea opened this issue Sep 5, 2016 · 1 comment · Fixed by #260
Closed

Subscribe to/Unsubscribe from an Issue or Merge Request #221

connorshea opened this issue Sep 5, 2016 · 1 comment · Fixed by #260
Labels
help wanted Good for newcomers

Comments

@connorshea
Copy link
Contributor

Add subscribe_to_* and unsubscribe_from_* methods to lib/client/issues.rb and lib/client/merge_requests.rb.
@asedge asedge added the help wanted Good for newcomers label Oct 17, 2016
@newellista
Copy link
Contributor

Unsubscribe should be implemented as POSTs to the unsubscribe endpoint, per the latest documentation.

newellista pushed a commit to newellista/gitlab that referenced this issue Feb 23, 2017
(Un)subscribe to issues and merge_requests
55d3100 
This resolves NARKOZ#221

Note that the documentation in the issue is incorrect wrt to the
unsubscribe endpoints.  Latest Gitlab documentation indicates that a
`POST` to `.../unsubscribe` is the correct method, rather than `DELETE`.
Also, verbs are `subscribe`/`unsubscribe` rather than `subscription`
@newellista newellista mentioned this issue Feb 23, 2017
Merged
asedge pushed a commit that referenced this issue Mar 3, 2017
@newellista @asedge
(Un)subscribe to issues and merge_requests (#260)
15c0d29 
* Update merge_request endpoints to new merge_requests endpoints. Resolves #229.
* (Un)subscribe to issues and merge_requests. Resolves #221.
epintozzi pushed a commit to epintozzi/gitlab that referenced this issue Mar 8, 2017
@newellista @epintozzi
(Un)subscribe to issues and merge_requests (NARKOZ#260)
3be515a 
* Update merge_request endpoints to new merge_requests endpoints. Resolves NARKOZ#229.
* (Un)subscribe to issues and merge_requests. Resolves NARKOZ#221.
epintozzi pushed a commit to epintozzi/gitlab that referenced this issue Mar 13, 2017
@newellista @epintozzi
(Un)subscribe to issues and merge_requests (NARKOZ#260)
7d6e839 
* Update merge_request endpoints to new merge_requests endpoints. Resolves NARKOZ#229.
* (Un)subscribe to issues and merge_requests. Resolves NARKOZ#221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Un)subscribe to issues and merge_requests newellista/gitlab
3 participants
@newellista @connorshea @asedge