Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Un)subscribe to issues and merge_requests #260

Merged
merged 4 commits into from
Mar 3, 2017
Merged

Conversation

newellista
Copy link
Contributor

This resolves #221

Note that the documentation in the issue is incorrect wrt to the
unsubscribe endpoints. Latest Gitlab documentation indicates that a
POST to .../unsubscribe is the correct method, rather than DELETE.
Also, verbs are subscribe/unsubscribe rather than subscription

Steve Newell added 3 commits February 14, 2017 16:48
This resolves NARKOZ#221

Note that the documentation in the issue is incorrect wrt to the
unsubscribe endpoints.  Latest Gitlab documentation indicates that a
`POST` to `.../unsubscribe` is the correct method, rather than `DELETE`.
Also, verbs are `subscribe`/`unsubscribe` rather than `subscription`
@asedge
Copy link
Collaborator

asedge commented Mar 2, 2017

@newellista Thanks! Would you mind adding an entry to the CHANGELOG.md for your contribution?

@asedge asedge merged commit 15c0d29 into NARKOZ:master Mar 3, 2017
@asedge
Copy link
Collaborator

asedge commented Mar 3, 2017

Thanks!

epintozzi pushed a commit to epintozzi/gitlab that referenced this pull request Mar 8, 2017
* Update merge_request endpoints to new merge_requests endpoints. Resolves NARKOZ#229.
* (Un)subscribe to issues and merge_requests. Resolves NARKOZ#221.
epintozzi pushed a commit to epintozzi/gitlab that referenced this pull request Mar 13, 2017
* Update merge_request endpoints to new merge_requests endpoints. Resolves NARKOZ#229.
* (Un)subscribe to issues and merge_requests. Resolves NARKOZ#221.
andrew added a commit to librariesio/gitlab that referenced this pull request Apr 11, 2017
* upstream/master:
  release 4.0.0
  Move .file_contents to RepositoryFiles module, matching GitlabHQ API doc.  Also update route so it actually works with APIv4.
  Fix .get_file for new APIv4 route
  Update gitignore
  Add ability to get all issues a merge_request will close (NARKOZ#271)
  Update CHANGELOG, add some missing entries.
  Block/unblock user now uses POST instead of PUT.  Fixes NARKOZ#262.
  Adds ability to create commits (NARKOZ#264)
  Rename "git hook" to "push rule".  Closes NARKOZ#233.
  Change project fork endpoint for v4 API. Closes NARKOZ#236.
  Add v4-endpoint to fetch all merge_requests for a milestone (NARKOZ#265)
  Fixes NARKOZ#222, using deploy_keys endpoint (NARKOZ#261)
  (Un)subscribe to issues and merge_requests (NARKOZ#260)
  Update merge_request endpoints to new merge_requests endpoints (NARKOZ#256)
  Fix failing test that was called with a pre-urlencoded string.
  Allow issues to use NAMESPACE/REPO identifier (NARKOZ#255)
  Feature/230 note that project id can also be a string (NARKOZ#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe to/Unsubscribe from an Issue or Merge Request
2 participants