Feature/230 note that project id can also be a string #253
Conversation
|
It is pretty needed :) |
|
This is already possible if you url encode your project string before using it as a parameter to one of the methods. I am not fond of adding code where documentation would do. @jvanbaarsen - I know you're busy but do you have an opinion here? |
|
when using CLI we should not expect users to url encode |
|
Good point. Have you written any tests that verify this functionality? I don't remember seeing any. |
|
@asedge I have added specs to verify that project string is url_encoded. Also made code change to support backword compatibility for users that already have url_encoded. |
bergholdt
force-pushed
the
feature/230-Note-that-project-ID-can-also-be-a-string
branch
from
cccc6a0 to
cb292bb
Compare
|
Note to self - always run all specs locally before push. Removed the backward compatibility code again...as it was not that compatible 😊 |
|
Thanks! |
This was changed in NARKOZ/gitlab#253, and as we depend on the master branch we immediately get this change.
|
Any chance we can get a gem release with this in? |
|
@orta Yes, "soon". Trying to button a few things up first. |
|
@orta |
* upstream/master: release 4.0.0 Move .file_contents to RepositoryFiles module, matching GitlabHQ API doc. Also update route so it actually works with APIv4. Fix .get_file for new APIv4 route Update gitignore Add ability to get all issues a merge_request will close (NARKOZ#271) Update CHANGELOG, add some missing entries. Block/unblock user now uses POST instead of PUT. Fixes NARKOZ#262. Adds ability to create commits (NARKOZ#264) Rename "git hook" to "push rule". Closes NARKOZ#233. Change project fork endpoint for v4 API. Closes NARKOZ#236. Add v4-endpoint to fetch all merge_requests for a milestone (NARKOZ#265) Fixes NARKOZ#222, using deploy_keys endpoint (NARKOZ#261) (Un)subscribe to issues and merge_requests (NARKOZ#260) Update merge_request endpoints to new merge_requests endpoints (NARKOZ#256) Fix failing test that was called with a pre-urlencoded string. Allow issues to use NAMESPACE/REPO identifier (NARKOZ#255) Feature/230 note that project id can also be a string (NARKOZ#253)
Make it possible to use NAMESPACE/PROJECT_NAME on all methods that uses project ID
ex.
gitlab project gitlab-org/gitlab-ce
gitlab milestones gitlab-org/gitlab-ce
gitlab tree gitlab-org/gitlab-ce
gitlab tags gitlab-org/gitlab-ce
...
Closes #230