Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test Updates #62

Closed
cartermak opened this issue Jul 28, 2023 · 2 comments
Closed

Integration Test Updates #62

cartermak opened this issue Jul 28, 2023 · 2 comments
Labels
enhancement New/improved features and capabilities

Comments

@cartermak
Copy link
Member

Improvements to build on #54:

  • Pull a version-specific build of the banananation JAR file from here
  • Pull (or otherwise store locally) a docker-compose for each Aerie version under test
  • Add a matrix of Aerie versions to test
@cartermak cartermak added the enhancement New/improved features and capabilities label Jul 28, 2023
@Navarro-Jonathan
Copy link
Contributor

Navarro-Jonathan commented Aug 3, 2023

One possible change is to remove the secrets from the workflow. The tests should work regardless of the workflow's secret's values, so those could be hardcoded. This would potentially make debugging easier if any authentication errors come up.

Relevant discussion: #54 (comment)

@cartermak cartermak mentioned this issue Aug 23, 2023
@cartermak
Copy link
Member Author

Mostly addressed by #88 . This doesn't automatically pull the banananation Jar, but instead we store the JARs for all compatible Aerie versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New/improved features and capabilities
Projects
None yet
Development

No branches or pull requests

2 participants