Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests #54

Merged
merged 14 commits into from
Aug 3, 2023
Merged

Add integration tests #54

merged 14 commits into from
Aug 3, 2023

Conversation

Navarro-Jonathan
Copy link
Contributor

  • Added functional integration tests. The old integration tests were not fully implemented and did not run on the current version of aerie-cli.
  • Integration tests now test a real aerie instance
  • Integration tests will add and remove data in the active aerie configuration. In the interest of not doing this to any remote aerie instances, the active configuration will be automatically set to localhost.
  • The banananation model and banananation command dictionary are both loaded into aerie for these tests
  • Added integration tests alongside unit tests in the GitHub Actions workflow.

@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:33 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:33 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:42 — with GitHub Actions Error
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:42 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:42 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow July 17, 2023 22:42 — with GitHub Actions Error
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 19, 2023 16:42 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 19, 2023 16:42 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 19, 2023 17:14 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 19, 2023 17:14 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 27, 2023 23:12 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 27, 2023 23:12 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 27, 2023 23:12 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow July 27, 2023 23:12 — with GitHub Actions Inactive
@cartermak cartermak added this to the v2 milestone Jul 28, 2023
@cartermak cartermak mentioned this pull request Jul 28, 2023
Closed
@Navarro-Jonathan Navarro-Jonathan marked this pull request as ready for review August 1, 2023 17:38
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 18:33 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 18:33 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow August 3, 2023 18:33 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow August 3, 2023 18:33 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 18:47 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 18:47 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow August 3, 2023 18:47 — with GitHub Actions Error
@Navarro-Jonathan Navarro-Jonathan had a problem deploying to integration-test-workflow August 3, 2023 18:47 — with GitHub Actions Failure
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:14 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:29 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:37 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:37 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:37 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:37 — with GitHub Actions Inactive
Navarro-Jonathan and others added 14 commits August 3, 2023 12:41
@Navarro-Jonathan
Add session to integration tests
7c0dc69
@Navarro-Jonathan
Add banananation files
825b0a9
@Navarro-Jonathan
Test model upload, use main typer app
3df576d
@Navarro-Jonathan
Run localhost session for testing
0a3ebea
@Navarro-Jonathan
Add commands to plans and models tests
1e56ccf
@Navarro-Jonathan
Move CLI call to improve readability
43ca50c
@Navarro-Jonathan
Test with empty 2 day plan
ad7df84
@Navarro-Jonathan
Test with baking bread
73916b1
@Navarro-Jonathan
Clean plans at both start and end
cd05fc0
@Navarro-Jonathan
Add 1.6.2 banananation model
32b8edf
@Navarro-Jonathan
Add integration tests to actions
d7fda47 
Fix integration test in github action workflow

Remove 3.9 temporarily

Improve docker compose calls

Move docker logic

Revert "Move docker logic"

This reverts commit 757a1e6.

Update docker calls

Improve integration output logs

Load docker compose file locally

Wait for aerie to be ready to accept connections

Add environment to workflow

Sleep for 1m instead of 30s
@Navarro-Jonathan
Split tests into 2 jobs
08895f3
@Navarro-Jonathan
Use start_offset in plans for integration tests
16b7c47
@Navarro-Jonathan
Test with admin secret from environment
a9e8bf9
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:44 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:44 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:44 — with GitHub Actions Inactive
@Navarro-Jonathan Navarro-Jonathan temporarily deployed to integration-test-workflow August 3, 2023 19:44 — with GitHub Actions Inactive
@Navarro-Jonathan
Copy link
Contributor Author

Navarro-Jonathan commented Aug 3, 2023 •
edited
Loading

  • The tests' plans now use start-offset, so they work with the newest version of aerie-cli.
  • The hasura admin secret is now being pulled as an environment variable for tests. The GitHub secret changes the Hasura secret from the default value, so now it will always pull the correct one.
  • I also made a minor change to the configuration for tests in a9e8bf9. The configuration was already being set to localhost at the start of the tests, but now it is also being set in the configuration line. This will further ensure localhost is used even if the configuration changes mid-test run. It is a rare case, but the cost to add this was low.

@Navarro-Jonathan Navarro-Jonathan merged commit 5b0d373 into develop Aug 3, 2023
@Navarro-Jonathan Navarro-Jonathan deleted the add-integration-tests branch August 3, 2023 21:35
@cartermak cartermak mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mythicaeda Mythicaeda Mythicaeda left review comments

@cartermak cartermak cartermak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
3 participants
@Navarro-Jonathan @cartermak @Mythicaeda