Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aerie 1.13.0 + Integration test with multiple Aerie versions #88

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Aerie 1.13.0 + Integration test with multiple Aerie versions #88

merged 3 commits into from
Oct 19, 2023

Conversation

cartermak
Copy link
Member

@cartermak cartermak commented Oct 19, 2023 •
edited
Loading

  • Update constraints query and corresponding integration tests
  • Adds test matrix to integration test workflow (but removes 1.12.0 since the constraint schema changes aren't backward-compatible)

@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:17 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 19:27 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:39 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:39 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:39 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:47 — with GitHub Actions Inactive
@cartermak cartermak force-pushed the feature--aerie-version-matrix branch from e914c2b to f0b79ff Compare October 19, 2023 21:54
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 19, 2023 21:54 — with GitHub Actions Inactive
@cartermak cartermak marked this pull request as ready for review October 19, 2023 22:06
@cartermak cartermak changed the title Integration test with multiple Aerie versions Aerie 1.13.0 + Integration test with multiple Aerie versions Oct 19, 2023
Mythicaeda
Mythicaeda approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

parkerabercrombie
parkerabercrombie reviewed Oct 19, 2023
View reviewed changes
.env
@@ -1,4 +1,4 @@
DOCKER_TAG=v1.12.0
DOCKER_TAG=v1.13.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to make this 1.13 instead of 1.14?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope; I was just focusing on 1.13.0 on this branch and have 1.14.0 updates on a separate branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I saw two PR's come in and must have gotten them confused. 👍

@cartermak cartermak merged commit 3968acf into develop Oct 19, 2023
@cartermak cartermak deleted the feature--aerie-version-matrix branch October 19, 2023 22:59
@cartermak cartermak mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerabercrombie parkerabercrombie parkerabercrombie left review comments

@Mythicaeda Mythicaeda Mythicaeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermak @parkerabercrombie @Mythicaeda