-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-memory checkpoint simulation #1323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienmaillard
added
performance
A code change that improves performance
feature
A new feature or feature request
scheduling
Anything related to the scheduling domain
simulation
Anything related to the simulation domain
labels
Feb 6, 2024
adrienmaillard
had a problem deploying
to
e2e-test
February 6, 2024 20:07 — with
GitHub Actions
Failure
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 6, 2024 20:22
5350091
to
b6b522f
Compare
adrienmaillard
had a problem deploying
to
e2e-test
February 6, 2024 20:22 — with
GitHub Actions
Failure
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 6, 2024 22:00
b6b522f
to
28e9789
Compare
adrienmaillard
had a problem deploying
to
e2e-test
February 6, 2024 22:00 — with
GitHub Actions
Failure
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 6, 2024 22:08
28e9789
to
db504bd
Compare
adrienmaillard
had a problem deploying
to
e2e-test
February 6, 2024 22:08 — with
GitHub Actions
Failure
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 7, 2024 01:56
db504bd
to
9b7d6be
Compare
adrienmaillard
had a problem deploying
to
e2e-test
February 7, 2024 01:56 — with
GitHub Actions
Failure
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 7, 2024 19:21
9b7d6be
to
69c335b
Compare
adrienmaillard
had a problem deploying
to
e2e-test
February 7, 2024 19:21 — with
GitHub Actions
Failure
adrienmaillard
temporarily deployed
to
e2e-test
February 7, 2024 19:33 — with
GitHub Actions
Inactive
Matt, I have not rewritten your part of the history. I think there is some stuff to squash, let me know what you want to do. |
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 9, 2024 00:38
69c335b
to
746c3c0
Compare
adrienmaillard
temporarily deployed
to
e2e-test
February 9, 2024 00:38 — with
GitHub Actions
Inactive
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 9, 2024 00:40
746c3c0
to
df833e1
Compare
adrienmaillard
temporarily deployed
to
e2e-test
February 9, 2024 00:40 — with
GitHub Actions
Inactive
adrienmaillard
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
February 9, 2024 00:43
df833e1
to
16957a5
Compare
adrienmaillard
temporarily deployed
to
e2e-test
February 9, 2024 00:43 — with
GitHub Actions
Inactive
adrienmaillard
requested review from
skovati,
Mythicaeda and
mattdailis
and removed request for
skovati
February 9, 2024 00:57
When we exit the simulation at time t, the engine has finished all work at time t and this has updated the value of resources. Consequently, the last interval should not be closed/open but closed/closed to be consistent with the state of the simulation engine.
dandelany
force-pushed
the
prototype/duplicatable-sim-engine
branch
from
June 18, 2024 20:45
4405891
to
50ec917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
A change that will require updating downstream code
feature
A new feature or feature request
performance
A code change that improves performance
scheduling
Anything related to the scheduling domain
simulation
Anything related to the simulation domain
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first part of this branch has been done by @mattdailis, it
Then, I took this work and integrated it into the scheduling agent. Here are some elements of this work:
SimulationFacade
has been completely overhauled to account for checkpoint simulation. It now takes care of updating the plan to simulate with child activities and activity durations.Other stuff:
DurationExpression
mainly)SimulationResults
object.This is not visible in the tests because the metric for simulation performance in scheduling has changed but all of this is greatly decreasing the required simulation time (for the scheduling tests at least...).
Verification
Few tests were added.
Documentation
Needs some documentation, at least for the configuration of cache size.
Future work