Immediate versions of load and activate
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Looks good. Nothing major just fix the order of Stem and Type. @dandelany is out today but I want to get his eyes on this too as he wasn't part of the meeting.
dandelany
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
👍 thanks @cartermak - this looks good to me & tests are passing. I'll coordinate with @goetzrrGit re: getting this released in the next Aerie version
goetzrrGit
approved these changes
Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the schema to create versions of
loadandactivatewithouttimeproperties, renamesimmediate_commandtoimmediate_fsw_command, and makes these types valid forimmediate_commands.