Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the TS Library #27

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

goetzrrGit
Copy link
Contributor

We didn't update the TS type file on @cartermak last PR #26

Includes the new immediate_load and immediate_activate by running npm run prepublishOnly

* Includes the new immediate_load and immediate_activate
Copy link

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a workflow automation to check for if the type-generating script hasn't been run (or to run the script)?

I think so, we don't have any workflow automation on the project atm :(

@goetzrrGit
Copy link
Contributor Author

Is it possible to add a workflow automation to check for if the type-generating script hasn't been run (or to run the script)?

I think so, we don't have any workflow automation on the project atm :(

@duranb
Copy link

duranb commented Nov 4, 2024

Is it possible to add a workflow automation to check for if the type-generating script hasn't been run (or to run the script)?

I think so, we don't have any workflow automation on the project atm :(

prepublishOnly should be automatically run when you run npm publish and the generated types.ts and schema.json files are included in the npm package. You technically could ignore those two files from git so you don't have to keep updating it on git when the script is updated.

@goetzrrGit
Copy link
Contributor Author

@duranb Are you saying this PR isn't really needed?

@duranb
Copy link

duranb commented Nov 4, 2024

@duranb Are you saying this PR isn't really needed?

I think so. Unless you find it beneficial to have the type accessible via the repo as well. I also haven't installed the package to confirm the files are included. I was just looking at the package.json to see what was included under files.

@goetzrrGit
Copy link
Contributor Author

@duranb Are you saying this PR isn't really needed?

I think so. Unless you find it beneficial to have the type accessible via the repo as well. I also haven't installed the package to confirm the files are included. I was just looking at the package.json to see what was included under files.

Got it. I will merge the PR as I use it sometimes as a reference or quick lookup and don't want to sift through the actual json spec which is not very readable

@goetzrrGit goetzrrGit merged commit adaf057 into develop Nov 4, 2024
1 check passed
@goetzrrGit goetzrrGit deleted the feature/immediate_load_activate_ts branch November 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants