Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates: Adding Checks and Resolving Inconsistencies #251

Merged
merged 65 commits into from
Aug 2, 2023
Merged

Updates: Adding Checks and Resolving Inconsistencies #251

merged 65 commits into from
Aug 2, 2023

Conversation

jenny-m-wood
Copy link
Collaborator

No description provided.

daniellegroenen and others added 30 commits January 5, 2023 13:27
@daniellegroenen
Update README.md
33de8e5
@daniellegroenen
Update README.md
63371d2
@daniellegroenen
Update README.md
01cd682
@daniellegroenen
Update README.md
88383d8 
Changed "Use" to "Using" in the last section to match the other sections.
added license_url_description_check field to rule_mapping
0d0820a
Added check message for license url description check
a904c5a
Added horizontal_resolution_presence_check to the rule_mapping and ch…
0b8e731 
…eck_messages
fixed field path
9b6172f
@smk0033
Standard Product Check added
c3bab5c
rule_mapping file for FreeAndOpenData check
8dee88d
added FreeAndOpenData check to check_messages
90b18e6
updated ends at present flag check to account for text values of False
1e331d6
fixed bugs for ends at presence flag check
a93a595
@slesaad
Work around and log invalid token & cmr response
b8069e7
@slesaad
Format
f3594d2
@slesaad
Update tests
49fba92
@slesaad
Add details to downloader error
b3c7ac4
@slesaad
Update tests
3923bb9
@svbagwell
Merge pull request #235 from NASA-IMPACT/feature-add_new_checks-jw
57b3046 
Added horizontal_resolution_presence_check
added specific DIF10 check for standard product
083d32e
updated output messages for standard product fails
bae889c
@svbagwell
Merge pull request #239 from NASA-IMPACT/feature-add_new_checks_shey
5e9d21c 
Standard Product Check added
@svbagwell
Merge pull request #237 from NASA-IMPACT/feature-add_new_checks-sydney
4e5d2a1 
Feature add new checks sydney
changed description fields to licensetext fields for license informat…
214a27e 
…ion check
added URL fields to license URL description check
75716a7
added a check for license URL description
df870c9
@svbagwell
Update pyQuARC/schemas/rule_mapping.json
d317704
updated echo-10 schema
ca0b2e4
updated umm-c schema
46fed0a
updated dif10 schema
ac774a5
esr0004 and others added 18 commits July 24, 2023 10:10
@esr0004
Update campaign long name presence check
55dba37
@jenny-m-wood
Merge pull request #243 from NASA-IMPACT/feature-add_new_checks
a105e27 
Feature add new checks
@jenny-m-wood
Merge pull request #242 from NASA-IMPACT/bug_fixes
89ee8de 
Bug fixes
@jenny-m-wood
Merge pull request #241 from NASA-IMPACT/schema_updates
2f9de0c 
Schema updates
@jenny-m-wood
Merge pull request #232 from NASA-IMPACT/daniellegroenen-readme-edits
40da310 
Update README.md
@jenny-m-wood
Merge pull request #246 from NASA-IMPACT/feature-add_new_checks-essence
cbf204f 
Update long name presence checks for instrument, platform, and campaign
@jenny-m-wood
Merge pull request #247 from NASA-IMPACT/feature-add_new_checks
40004bc 
Feature add new checks (Changes to instrument, platform, and campaign long name presence checks.)
Added Granule Campaign Name Presence Check
0bb815b
Removed online_access_url_description_check since the url_desc_presen…
178d4c5 
…ce_check achieves the same result
Removed online_resource_url_description_check since the url_desc_pres…
de0c5dd 
…ence_check achieves the same result
@jenny-m-wood
Merge pull request #248 from NASA-IMPACT/dev-jenny
74be283 
Resolving Minor Inconsistencies
Removed data_center_short_name_gcmd_check since the organization_shor…
10b8195 
…t_name_gcmd_check achieves the same result
Modified rule mapping for collection_citation_presence_check
8ee9946
Resolving issues with the validate_beginning_datetime_against_granule…
a2f6112 
…s check
@jenny-m-wood
Merge pull request #249 from NASA-IMPACT/dev-jenny
ab470ce 
Resolving inconsistencies
Added data_format_presence_check for collections
589a6ad
Removed echo-g rule mapping from online_resource_url_presence_check
5db98b8
@jenny-m-wood
Merge pull request #250 from NASA-IMPACT/dev-jenny
e6341f4 
Adding data format presence check
@jenny-m-wood jenny-m-wood requested a review from slesaad August 1, 2023 13:57
@slesaad
Copy link
Member

slesaad commented Aug 1, 2023 •
edited
Loading

Since we're trying to merge to master, we'll need to bump the version up and we'll need an entry in the CHANGELOG.md about the changes added to this release.

Also, looks like there are some other PRs that we'd want to add in this release:
#245
#240

I'm going to merge them to dev too.

@jenny-m-wood jenny-m-wood merged commit 88b7ac5 into master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slesaad slesaad slesaad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jenny-m-wood @slesaad @daniellegroenen @smk0033 @svbagwell @code-geek @esr0004