Standard product check #285
Conversation
Updates: Adding Checks and Resolving Inconsistencies
Minor fixes and additional checks: - Updated UMM-C schema file - Added science_keywords_presence_check - Added DOI authority presence check for echo-c and umm-c - Adjusted output message for url_check - Added orbit fields to rule_mapping for spatial_extent_fulfillment_check - Resolved ISO standard type in check_messages
Updates to README and umm-g schema file
pyQuARC DOI creation updates
Created new version for citation file and README updates
pyQuARC/code/custom_validator.py
Outdated
| @staticmethod | ||
| def standard_product_check(*field_values): | ||
| """ |
There was a problem hiding this comment.
Why rename the method? What's the benefit of using one or the other method name? Can the older model name not be used?
There was a problem hiding this comment.
we already have a dif_standard_product_check method, no?
There was a problem hiding this comment.
Yes, we have dif_standard_product_check that is used to check the extended metadata for DIF schema, but the standard_product_check is used to check the StandardProduct key inside the collection for schema echo-c and umm-c.
I thought, creating a new function solved the problem, but it shows the error again and now I changed the code which is different from the previous function dif_standard_product_check .
There was a problem hiding this comment.
If it's just checking values in a constrained list, don't we already have a check that does this? why start a new one?
There was a problem hiding this comment.
Looks like Standard Product Check is using the already existing one_item_presence_check check, which goes like this:
def one_item_presence_check(*field_values):
"""
Checks if one of the specified fields is populated
At least one of the `field_values` should not be null
It is basically a OneOf check
"""
validity = False
value = None
for field_value in field_values:
if field_value:
value = field_value
validity = True
break
return {"valid": validity, "value": value}This check is failing for the collection mentioned in the issue because the value is False and the if field_value: clause fails. It can be remedied by doing something like this instead:
if field_value is not None:There was a problem hiding this comment.
Thank you @slesaad didi. Worked on that.
There was a problem hiding this comment.
Did you test it? Everything working well?
There was a problem hiding this comment.
I tested it on the "UMM-C record (C1577484501-LARC_ASDC)". Yes, everything working well.
This is the pull request to solve this issue.
Overview:
In the pyQuarc, while running the collection, it showed the warning message like this:
Changes made:
Added a standard_product_check function in the custom_validator file according to the rule mapping.json and check message.json. Both JSON uses the standard_product_check function but the function was not created.
Now, no error is shown.
Tested on this ' C1577484501-LARC_ASDC' (umm-c) collection to make sure the if the warning shows up.