-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: titiler upgrade, optional custom base path for apis, optional cloudfront #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydocstyle fixes format isort changes optional config format config changes format config changes construct change
I can't update the diagram b/c it's draw.io.
…he veda-backend (#229)
Run cdk diff on specific stage based on the target branch in pre deployment action.
ref #234 This PR aims to update titiler-pgstac from version 0.2.3 to 0.8.0. Doing so, will also update titiler, rio-tiler, morecantile, fastapi and pydantic. Endpoint changes - ~~Use `/collections/{collection_id}/items/{item_id}` prefix for Item endpoint.~~ I was able to keep this as it was (`{endpoint}/stac/info?collection=collection1&item=item1`) - `post_process=` -> `algorithm=` - change tile url path parameter order from `/tiles/{searchid}/{TileMatrixSetId}/{z}/{x}/{y`} to `/{searchid}/tiles/{TileMatrixSetId}/{z}/{x}/{y}` ``` # Before {endpoint}/mosaic/tiles/20200307aC0853900w361030/0/0/0 # Now {endpoint}/mosaic/20200307aC0853900w361030/tiles/0/0/0 ``` - replace `/{searchid}/{z}/{x}/{y}/assets` endpoints by `/{searchid}/tiles/{z}/{x}/{y}/assets` - replace - by _ in query parameters - coord-crs -> coord_crs - dst-crs -> dst_crs - remove `max_size` default for mosaic's `/statistics [POST]` endpoint breaking change - add `/bbox` and `/feature [POST]` optional endpoints
# What - Use fast-api root path configuration and mangum api_base_path instead of overwriting the api host in the http lambda integration - Simplify custom domain management. If using cloudfront, do not create custom api-specific subdomains--just use the default apigateway urls route based on root path settings provided in raster and stac api configuration.
anayeaye
changed the title
feat! titiler upgrade, optional custom base path for apis, optional cloudfront
feat!: titiler upgrade, optional custom base path for apis, optional cloudfront
Nov 6, 2023
enable custom colormaps and add custom colormap for EPA dataset
…A-IMPACT/veda-backend into fix/configure-overwrite-host
# What - When a custom host is configured, overwrite the host in the api integration (bring back the parameter mapping method introduced in #229) - Include origin_path in cloudfront ingest api behavior. Note: this path will not work until the root_path is changed to `api/ingest` in the ingest api - Domain construct now only generates custom subdomains for endpoints when configured (existing stacks must provide new configuration variable). _Note: indentation changes that wrap all subdomain constructs make the change appear larger than they really are. The change removes an unused shared subdomain construct and only generates api-specific subdomains when create subdomains configuration is true._ ## Environment variable changes ### New `VEDA_CUSTOM_DOMAIN` optional configuration to provide a complete url for host overrides in lambda APIs (i.e. `dev.somedomain.com`) ### Removed `VEDA_DOMAIN_SHARED_SUBDOMAIN` is no longer used (logic is managed with custom subdomains config below) ### New+Breaking `VEDA_DOMAIN_CREATE_CUSTOM_SUBDOMAINS` boolean defaults false. Existing deployments with custom subdomains for each raster and stac api endpoints need to set this variable to TRUE.
ranchodeluxe
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late to this party 🥳! Bu LGTM
ividito
approved these changes
Nov 13, 2023
smohiudd
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/api/stac
and/api/raster
) feat: add configuration for deploying a cloudfront distribution for the veda-backend #229, fix(api)!: use root path for prefixing #241How tested
A temporary test stack was deployed to confirm that raster-api works as expected and that the two-subdomain staging-stac and staging-raster pattern is still supported. The pre-deploy diff action for this pr confirms that the raster API lambda will be upgraded and no domain name changes will be caused.