Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raster): add custom colormap for EPA dataset #243

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

vincentsarago
Copy link
Contributor

@@ -8,7 +8,9 @@
inst_reqs = [
"boto3",
"titiler.pgstac==0.8.0",
"titiler.extensions[cogeo]>=0.15.0,<0.16",
"titiler.core>=0.15.1,<0.16",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

titiler.core.dependencies.create_colormap_dependency was added in 0.15.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentsarago I noticed the bidx/asset_bidx change in the titiler changelog. Will this asset_bidx parameter usage still be supported in v0.15.4+?

    sourceParams:
      asset_bidx: cog_default|1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asset_bidx is the good way to go 👍

it enable more granular band selection. if you endup doing asset_bidx: [asset1|1, asset2|1] , using bidx=1 will just be easier to write.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I just confirmed the current usage is not impacted!

@vincentsarago vincentsarago changed the title add custom colormap for EPA dataset feat(raster): add custom colormap for EPA dataset Nov 2, 2023
@j08lue
Copy link

j08lue commented Nov 2, 2023

Awesome, thanks @vincentsarago.

We need to test this somehow and verify with the data provider that the color map is correct.

We should also rename the colormap to epa-ghgi-ch4, please.

I'll try to organize for someone to complete these steps.

@anayeaye
Copy link
Collaborator

anayeaye commented Nov 6, 2023

The latest is running in the test stack here: https://test-raster.delta-backend.com/docs

@anayeaye anayeaye merged commit d3bf6ff into develop Nov 7, 2023
4 checks passed
@anayeaye anayeaye deleted the feat/add-epa-custom-colormap branch November 7, 2023 23:28
anayeaye added a commit that referenced this pull request Nov 13, 2023
…cloudfront (#244)

# What
- adds optional configuration to deploy all endpoints with a custom root
path (i.e. `/api/stac` and `/api/raster`) #229, #241
- adds support for using a cloudfront as a reverse proxy #229, #241,
#245
- titiler-pgstac upgraded from 0.2.3 to 0.8.0 #239
- titiler upgrade for custom colormap configuration #243

# How tested
A temporary test stack was deployed to confirm that raster-api works as
expected and that the two-subdomain staging-stac and staging-raster
pattern is still supported. The [pre-deploy diff action for this
pr](https://github.com/NASA-IMPACT/veda-backend/actions/runs/6791564314/job/18463354484#step:11:919)
confirms that the raster API lambda will be upgraded and no domain name
changes will be caused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants