-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): add otel to ingest API #342
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
"""Observability utils""" | ||
from typing import Callable | ||
|
||
from aws_lambda_powertools import Logger, Metrics, Tracer | ||
from aws_lambda_powertools.metrics import MetricUnit # noqa: F401 | ||
|
||
from fastapi import Request, Response | ||
from fastapi.routing import APIRoute | ||
|
||
logger: Logger = Logger(service="raster-api", namespace="veda-backend") | ||
metrics: Metrics = Metrics(service="raster-api", namespace="veda-backend") | ||
tracer: Tracer = Tracer() | ||
|
||
|
||
class LoggerRouteHandler(APIRoute): | ||
"""Extension of base APIRoute to add context to log statements, as well as record usage metricss""" | ||
|
||
def get_route_handler(self) -> Callable: | ||
"""Overide route handler method to add logs, metrics, tracing""" | ||
original_route_handler = super().get_route_handler() | ||
|
||
async def route_handler(request: Request) -> Response: | ||
# Add fastapi context to logs | ||
ctx = { | ||
"path": request.url.path, | ||
"route": self.path, | ||
"method": request.method, | ||
} | ||
logger.append_keys(fastapi=ctx) | ||
logger.info("Received request") | ||
metrics.add_metric( | ||
name="/".join( | ||
str(request.url.path).split("/")[:2] | ||
), # enough detail to capture search IDs, but not individual tile coords | ||
unit=MetricUnit.Count, | ||
value=1, | ||
) | ||
tracer.put_annotation(key="path", value=request.url.path) | ||
tracer.capture_method(original_route_handler)(request) | ||
return await original_route_handler(request) | ||
|
||
return route_handler |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we log the err here?
f"Unhandled exception {err=}"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we have been doing the same in raster api and stac api so this may be for a discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to log the error but we could handle that in a separate PR including raster and stac. Or include it in this PR for all the services