feat(otel): add otel to ingest API #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
anayeaye
approved these changes
Apr 22, 2024
| """Handle exceptions that aren't caught elsewhere""" | ||
| metrics.add_metric(name="UnhandledExceptions", unit=MetricUnit.Count, value=1) | ||
| logger.exception("Unhandled exception") | ||
| return JSONResponse(status_code=500, content={"detail": "Internal Server Error"}) |
There was a problem hiding this comment.
Can we log the err here? f"Unhandled exception {err=}"?
There was a problem hiding this comment.
I see that we have been doing the same in raster api and stac api so this may be for a discussion.
There was a problem hiding this comment.
I think it makes sense to log the error but we could handle that in a separate PR including raster and stac. Or include it in this PR for all the services
botanical
added a commit
that referenced
this pull request
May 6, 2024
### Breaking - #356 #### Breaking changes notes Breaking: `VEDA_COGNITO_DOMAIN` configuration now required along with one time administrator step to update existing user pool client allowed callback urls with the ingest-api's URL ### Added - #342 - #330 - #323 ### Changed/Updated - #355 - #340 ### Fixed 1. - #367 2. - #365 3. - #361 4. - #360 5. - #358 8. - #345 9. - #344 12. - #339 13. - #338 14. - #337 15. - #335 16. - #334 17. - #331 20. - #329 21. - #327 22. - #326 23. - #325 24. - #324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#289
What?
Testing?
otelstack and viewed generated metrics and logs using POC Grafana instance