-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db)!: update collection summaries on load items #344
Merged
anayeaye
merged 15 commits into
develop
from
fix/update-collection-summaries-on-load-items
Mar 28, 2024
Merged
fix(db)!: update collection summaries on load items #344
anayeaye
merged 15 commits into
develop
from
fix/update-collection-summaries-on-load-items
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uding end_datetime (not just nominal datetime)
…ents in stac ingest loader
anayeaye
changed the title
fix: update collection summaries on load items
fix(db)!: update collection summaries on load items
Mar 26, 2024
Ingest api tests are now failing with the same moto version issue that @stephenkilbourn has been fighting I think. I will dig into that next, too. |
…ger convert numbers when loading in DDB
stephenkilbourn
approved these changes
Mar 28, 2024
@@ -1,11 +1,13 @@ | |||
import base64 | |||
import json | |||
from datetime import timedelta | |||
from math import isclose | |||
|
|||
# from math import isclose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this import line just be deleted?
botanical
added a commit
that referenced
this pull request
May 6, 2024
### Breaking - #356 #### Breaking changes notes Breaking: `VEDA_COGNITO_DOMAIN` configuration now required along with one time administrator step to update existing user pool client allowed callback urls with the ingest-api's URL ### Added - #342 - #330 - #323 ### Changed/Updated - #355 - #340 ### Fixed 1. - #367 2. - #365 3. - #361 4. - #360 5. - #358 8. - #345 9. - #344 12. - #339 13. - #338 14. - #337 15. - #335 16. - #334 17. - #331 20. - #329 21. - #327 22. - #326 23. - #325 24. - #324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
collection_temporal_extent_max
function that includes the maximum itemend_datetime
which is significantly different from an item's nominaldatetime
in collections of items that represent an entire year or range or dates.How tested
I removed the latest date from the geoglam collection's temporal extent and datetime summaries then ingested a single item to /ingestions which triggered both the summaries and extent functions to be executed. Verified in dev.openveda.cloud/api/stac/collections/geoglam.