-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOI Feature Specification #1207
Comments
@AliceR I made edits directly in the original comment, I hope that's okay. Let me know if you have any questions |
I also made some edits. @aboydnw I made a slight edit of your note:
To this:
We have a bug where the AOI is actually selected (internally, the app knows it's selected and analysis can be ran for that AOI), but visually it's not shown as selected. That's the bug reported here: US-GHG-Center/veda-config-ghg#406 I've also added |
**Related Ticket:** #950 US-GHG-Center/veda-config-ghg#406 ### Description of Changes The fix make sures that selected AOIs persist across page reloads. Previously when an AOI was selected, the selection was lost after a page reload (visually, the polygon was de-selected). The fix checks for existing AOI selections on load and adjusts the mode accordingly. We also started to enhance the documentation and tests around AOI behavior (thanks to @AliceR): #1207 ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing 1. Draw a polygon 2. Once you finish drawing, see that the AOI is selected 3. Reload the page 4. Verify that the AOI is still selected 5. Choose a preselected area (one of the state presets) 6. Reload the page and verify that it remains un-selectable
**Related Ticket:** #1207 ### Description of Changes So far, added a first test for the scenario "User selects a pre-defined AOI". I'm adding some `data-testid` properties to relevant dom elements in order to select them in the test. Also, added some documentation on how to run the tests. @hanbyul-here if you want to try that on your machine, and let me know if it works? ### Notes & Questions About Changes more tests to be added ### Validation / Testing Follow the instructions added to the SETUP.md guide to run the tests locally. See if they pass!
Context
While starting to investigate a bug related to the AOI (Area of Interest) feature, I noticed several other related issues that may be interconnected. To effectively address the root cause of these issues, it would be beneficial to clearly define the expected behavior of the AOI feature.
I used the Gherkin syntax, which will be helpful when writing tests for the code as well.
Acceptance Criteria
Request for Input: To ensure I cover all necessary scenarios, could the team help clarify the expected behavior of the AOI feature? Are there any additional scenarios or edge cases that I may have missed?
Next Steps: Once we establish a clear understanding of the expected behavior, I can proceed with troubleshooting the identified bugs more effectively.
Related Tickets
cc @aboydnw @faustoperez @dzole0311 et al
The text was updated successfully, but these errors were encountered: