Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape special characters in regex expression #1204

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Escape special characters in regex expression #1204

merged 1 commit into from
Oct 21, 2024

Conversation

AliceR
Copy link
Member

@AliceR AliceR commented Oct 21, 2024

Fix #1059

Related Ticket: #1059

Description of Changes

We added a regex pattern to escape special characters. It is used in the text highlight function, to indicate search results as we type.

Notes & Questions About Changes

Collaboration with @dzole0311 and github co-pilot 🤓

Validation / Testing

  • Go to Dataset Catalog
  • Type emissions ( in the search bar
  • It should display corresponding results

@AliceR AliceR requested a review from dzole0311 October 21, 2024 09:19
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 9c338ab
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67161cb70f4d8b0008965024
😎 Deploy Preview https://deploy-preview-1204--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a few search keywords and special characters, works great! thanks for fixing @AliceR 🥳

@AliceR AliceR merged commit 57bae88 into main Oct 21, 2024
8 checks passed
@AliceR AliceR deleted the 1059-fix-regex branch October 21, 2024 09:25
@hanbyul-here hanbyul-here mentioned this pull request Oct 29, 2024
snmln added a commit that referenced this pull request Oct 30, 2024
You can find VEDA Dashboard preview link to test these changes:
NASA-IMPACT/veda-config#470

## 🎉 Features
- Cookie consent component:
#1163,
#1165,
#1127,
#1177
- Stories Hub export in #1162
- Expose As Is - PageHeader, LinkElement Prop & Logo in
#1184
## 🚀 Improvements

- Add docs for registry dev in
#1169
- Timeline date selection centering functionality in
#1181
- Deprecate old explore page, Mapbox component
#1176
- Update doc with new diagrams about general architecture in
#1195
-  Add playwright in #1139
- Pre-select AOIs that have the "selected" prop set to true in
#1215
- 
## 🐛 Fixes
- Check dastaset analysis exclude attribute before running analysis in
#1175
- Restrict dynamic colormaps to applicable layer types in
#1183
- Fix external link badge display for tools hosted under the same domain
in #1192
- Escape special characters in regex expression when searching datasets
in #1204


### New Contributors
* @snmln made their first contribution in
#1127
* @AliceR made their first contribution in
#1204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Searching datasets using special characters sometimes errors out
2 participants