Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] v5.9.0 #1224

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[Release] v5.9.0 #1224

merged 2 commits into from
Oct 30, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Oct 29, 2024

You can find VEDA Dashboard preview link to test these changes: NASA-IMPACT/veda-config#470

🎉 Features

🚀 Improvements

🐛 Fixes

New Contributors

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit ebcaff6
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67213f05ab52c60008d208d4
😎 Deploy Preview https://deploy-preview-1224--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

@snmln for rescale values, some datasets show like this where the slider isn't functional. I can't tell what the common factor between them is, but I have noticed it on Difference CO2 and Gross Primary Productivity in the preview
image

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Oct 29, 2024

Rescale values get cut off when its a longer #, are we okay with that @aboydnw ?

Screen.Recording.2024-10-29.at.2.09.17.PM.mov

@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

Yeah I'm okay with that for now, I created a ticket to followup #1226

@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

Okay I haven't found any other issues. The only thing I think we should look at is that rescale value issue @snmln , we should at least know why it's not working. Like is it something about the configuration of that dataset or something else? Ideally we'd fix it before releasing but maybe that depends on what the issue is and how tricky of a fix it is

@snmln
Copy link
Contributor

snmln commented Oct 29, 2024

@aboydnw I believe it is related to the dataset and the Min and Max points being -.00000015 and .00000015 so the original increment of .001 that I had set based on the dev environment datasets wont work. I believe that would present in the error you are seeing. I am exploring a potential solution currently and will keep you posted if that will correct the problem.

@snmln
Copy link
Contributor

snmln commented Oct 29, 2024

@aboydnw I have a solution locally but need to validate with some more testing. To not hold back the release I am going to remove the range slider from this release.

This reverts commit 233a31c, reversing
changes made to 46e1c5d.
@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

@snmln okay sounds good, then we can target the fix and #1226 for the next release

@snmln snmln closed this Oct 29, 2024
@snmln snmln reopened this Oct 29, 2024
@snmln snmln merged commit 179976e into main Oct 30, 2024
14 checks passed
@snmln snmln deleted the release/v5.9.0 branch October 30, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants