Update tsconfig and make nav interfaces exposable for consumption #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sandrahoang686
changed the title
sandrahoang686
requested review from
dzole0311,
hanbyul-here,
AliceR,
vgeorge and
snmln
dzole0311
approved these changes
Nov 6, 2024
|
Thanks for fixing, I'm getting the correct type annotations now ✅ |
sandrahoang686
force-pushed
the
1186-techdebt-expose-types-for-library
branch
from
b8366ef
to
0839c98
Compare
hanbyul-here
approved these changes
Nov 7, 2024
hanbyul-here
reviewed
Nov 7, 2024
| @@ -5,6 +5,7 @@ | |||
| "moduleResolution": "node", | |||
| "esModuleInterop": true, | |||
| "strictNullChecks": true, | |||
| "declaration": true, | |||
There was a problem hiding this comment.
for my education, can you tell me what this line does?
There was a problem hiding this comment.
here is more about it https://www.typescriptlang.org/tsconfig/declaration.html
Merged
AliceR
added a commit
that referenced
this pull request
Nov 12, 2024
## 🎉 Features * Card image/description independent of hero image/description by @dzole0311 in #1244 ## 🚀 Improvements * Cookie consent code cleanup by @snmln in #1199 , and @hanbyul-here in #1240 , and @hanbyul-here in #1241 * Add ADR about design system change by @j08lue in #890 * Update condition to run playwright tests on release branches by @dzole0311 in #1228 * Update STYLE_GUIDE.md by @AliceR in #1227 * Fix lint configuration by @AliceR in #1219 * Add tests for the AOI feature specification by @AliceR in #1216 * Set data catalog filters to be closed by default by @vgeorge in #1243 * Update tsconfig and make nav interfaces exposable for consumption by @sandrahoang686 in #1223 ## 🐛 Fixes * Hotfix to hide the external link badge from cards by @dzole0311 in #1231 ## New Contributors * @vgeorge made their first contribution in #1243 **Full Changelog**: v5.9.0...v5.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1186
Related PR: developmentseed/next-veda-ui#10
Note
To expose interfaces from veda-ui - they should be defined in
.tsfiles vs.d.tsfiles. This is because parcel isn't building the typescript definition files intolib/index.d.tsbut does so when the file is.ts.When building the library with
.d.tsextension - there are NO type hints from NextInstance sideWhen building the library with
.tsextension - there are type hints form NextInstance sideDescription of Changes
Notes & Questions About Changes
Found this thread about typescript definition files and parcel build here parcel-bundler/parcel#1240
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}