Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tsconfig and make nav interfaces exposable for consumption #1223

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Update tsconfig and make nav interfaces exposable for consumption #1223

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8200621
update tsconfig and update type imports
sandrahoang686 Oct 29, 2024
0839c98
change nav file type
sandrahoang686 Nov 4, 2024
0438c6b
expose NavItemType
sandrahoang686 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/scripts/components/common/page-header/default-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getString, getNavItemsFromVedaConfig } from 'veda';
import { InternalNavLink, ExternalNavLink, ModalNavLink, DropdownNavLink, NavItemType } from '$components/common/page-header/types.d';
import { InternalNavLink, ExternalNavLink, ModalNavLink, DropdownNavLink, NavItemType } from '$components/common/page-header/types';

import {
STORIES_PATH,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/components/common/page-header/nav-menu-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { DropMenu, DropMenuItem } from '@devseed-ui/dropdown';
import DropdownScrollable from '../dropdown-scrollable';
import GoogleForm from '../google-form';
import { LinkProperties } from '../card';
import { AlignmentEnum, InternalNavLink, ExternalNavLink, NavLinkItem, DropdownNavLink, ModalNavLink, NavItem, NavItemType } from './types.d';
import { AlignmentEnum, InternalNavLink, ExternalNavLink, NavLinkItem, DropdownNavLink, ModalNavLink, NavItem, NavItemType } from './types';
import GlobalMenuLinkCSS from '$styles/menu-link';
import { useMediaQuery } from '$utils/use-media-query';

Expand Down
0 .../components/common/page-header/types.d.ts → ...ts/components/common/page-header/types.ts
View file
Open in desktop
File renamed without changes.
8 changes: 7 additions & 1 deletion app/scripts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import StoriesHubContent from '$components/stories/hub/hub-content';
import { useFiltersWithQS } from '$components/common/catalog/controls/hooks/use-filters-with-query';
import PageHeader from '$components/common/page-header';
import LogoContainer from '$components/common/page-header/logo-container';
import type { NavItem, InternalNavLink } from '$components/common/page-header/types';


export {
Expand All @@ -42,6 +43,11 @@ export {
ReactQueryProvider,
StoriesHubContent,
LogoContainer,

// HOOKS and utility functions
useFiltersWithQS
useFiltersWithQS,

// TYPES
NavItem,
InternalNavLink
};
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"moduleResolution": "node",
"esModuleInterop": true,
"strictNullChecks": true,
"declaration": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my education, can you tell me what this line does?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is more about it https://www.typescriptlang.org/tsconfig/declaration.html

"baseUrl": "./",
"jsx": "react",
"paths": {
Expand Down
Loading