-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want validate to raise a WARNING when differing versions of IM are used within a bundle #210
Comments
May be something we can raise as part of #188 |
@jordanpadams Jordan, would you clarify if the versions referring to are the versions from the label only or from the schemas and the schematrons as well? Would validate keep a track of all versions from all labels and at the end report that there are more than one versions? What if the user really is OK with it (as they are now)? |
@qchaupds let's warn for just the version of the labels. i know we read in the "stack" of dictionaries that each of the LDDs use, but let's not include those in this warning check. |
The following flag: --prefer-all-labels-same-information-model-version will be added to allow the user to see a warning in the report if not all versions of the (IM) are the same. Without the flag, there will be no warning. This flag should work for pds4.bundle and multiple targets with the -t parameter. An example WARNING message:
These two labels have different IM versions. % grep information_model_version src/test/resources/github210/*.xml | egrep "bundle_cassini|Missing_Area_tag.xml" |
…d in the same run and optionally report a warning in the report 1. Added resource github188 to src/test/resources 2. Added resource github210 to src/test/resources 3. Add new class to keep a list of unique IMs processed in LabelUtil.java 4. Add logic to register IM version for each label to LocationUtil.java and many debugs to find the bug in LabelValidator.java 5. Fix bug by setting schemaLocation for each label to allow multiple versions of the IM to be processed in LabelValidationRule.java 6. Consolidate long functions into shorter functions for readability in LabelValidationRule.java 7. Add debug logging to SchemaValidator.java 8. Add logic to report warning if requested for labels processed if multiple versions of IM processed in ValidateLauncher.java 9. Add new parameter PREFER_ALL_LABELS_SAME_INFORMATION_MODEL_VERSION to ConfigKey.java 10. Add new parameter PREFER_ALL_LABELS_SAME_INFORMATION_MODEL_VERSION to Flag.java 11. Add new parameter PREFER_ALL_LABELS_SAME_INFORMATION_MODEL_VERSION to FlagOptions.java 12. Add github188 and github210 tests to feature file validate.feature Refs: #188 As a user, I want to validate a bundle that uses multiple versions of the Information Model / Discipline LDDs #210 As a user, I want validate to raise a WARNING when differing versions of IM are used within a bundle
…back because report of WARNING is now default 1. Remove references to optional flag to report WARNING for multiple IM version in ConfigKey.java 2. Remove references to optional flag to report WARNING for multiple IM version in Flag.java 3. Remove references to optional flag to report WARNING for multiple IM version in FlagOptions.java 4. Modify failed test cases due to the WARNING messages are now automatic from feature file validate.feature 5. Remove some tests that are not as useful from feature file validate.feature Refs: #188 As a user, I want to validate a bundle that uses multiple versions of the Information Model / Discipline LDDs #210 As a user, I want validate to raise a WARNING when differing versions of IM are used within a bundle
@jordanpadams @qchaupds |
Is your feature request related to a problem? Please describe.
Per https://pds-jira.jpl.nasa.gov/projects/SW/issues/SW-28:
Triage Response
This should be an optional flag that a user can enable if they would prefer all dictionaries follow the same IM version. Many bundles no longer follow this paradigm, but a warning may be useful here as it throws our software through a loop when we have differing versions ingested all at once.
The text was updated successfully, but these errors were encountered: