Skip checksum handling if no checksum check is possible

[jordanpadams]

If we know there is no checksum manifest or a checksum in the label, we don't need to handle any checksums.

Previous functionality would continue through this method and generate a checksum, significantly slowing down execution (especially for very large files).

With debugging enabled, here is some of the output that include the generation of a checksum for the file:

[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240
[main] DEBUG gov.nasa.pds.tools.util.MD5Checksum - createChecksum:url,bytesRead file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img,10240

followed by a note that we don't do anything with it:

[main] DEBUG gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule - handleChecksum:No checksum to compare against in the product label for 'file:/Users/jpadams/test/geo_issue_20221201/s_07171001_sim.img'

new functionality now eliminates the generation of a checksum for the file for no reason.

[al-niessner]

My only question is the checksum required or not in the PDS4 product? If so, then this should fail noisily.

[nutjob4life]

👍

[jordanpadams]

My only question is the checksum required or not in the PDS4 product? If so, then this should fail noisily.

@al-niessner it is not required in the label. if it were, the schema validation would catch this and raise an error.

eventually, we plan on managing checksums via the registry and use that for integrity checking, versus putting this information in the metadata labels.