Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip checksum handling if no checksum check is possible #565

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Skip checksum handling if no checksum check is possible #565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56dc4ee
Skip checksum handling if no checksum check is possible
jordanpadams Dec 1, 2022
f51e856
Update FileReferenceValidationRule.java
al-niessner Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,13 @@ private void handleChecksum(ValidationTarget target, URL urlRef, TinyNodeImpl fi
String checksumInLabel) throws Exception {
LOG.debug("handleChecksum:target,urlRef,checksumInLabel {},{},{}", target, urlRef,
checksumInLabel);
if (checksumManifest.isEmpty() && (checksumInLabel == null || checksumInLabel.isEmpty())) {
String message = "No checksum found in the manifest for '" + urlRef + "'";
if (!checksumManifest.containsKey(urlRef) && (checksumInLabel == null || checksumInLabel.isEmpty())) {
String message = "No checksum found in the manifest for '" + urlRef + "' and not checksum label in product";
LOG.debug("handleChecksum:" + message);

// If there is no checksumManifest and no checksum in the label, we don't need to do anything
// with a checksum for this urlRef
return;
}

String generatedChecksum = MD5Checksum.getMD5Checksum(urlRef);
Expand Down